]> git.koha-community.org Git - koha.git/commit
Bug 16967: Remove the use of "onclick" from serial frequency and numbering management
authorOwen Leonard <oleonard@myacpl.org>
Fri, 22 Jul 2016 18:48:36 +0000 (14:48 -0400)
committerKyle M Hall <kyle@bywatersolutions.com>
Mon, 12 Sep 2016 15:35:22 +0000 (15:35 +0000)
commit9707a439cbf152752f9f39ebee17c6976f6f7dc6
tree324e3a8cedefb7d52872ebb6003385f8d380bae6
parent062a70cb61f0604e3c79c3f2c08dbf1e218c9a20
Bug 16967: Remove the use of "onclick" from serial frequency and numbering management

This patch removes instance of "onclick" from the templates for serial
frequency and numbering management. Events are now defined in the
JavaScript.

To test, apply the patch and go to Serials -> Manage frequencies.

 - In the list of frequencies, click the "Delete" button for a frequency
   which is in use by at least one subscription. In the confirmation
   dialog, clicking the "Show subscriptions" link should display a list
   of titles.
 - Edit or create a frequency.
 - To test that the form submission validation is still working
   correctly, enter non-numeric data in the "issues per unit" field and
   submit the form. This should trigger an error.

In Serials -> Manage numbering patterns:

 - In the list of numbering patterns, click the "Delete" button for a
   pattern which is in use by at least one subscription. In the
   confirmation dialog, clicking the "Show subscriptions" link should
   display a list of titles.
 - Edit or create a numbering pattern.
 - Confirm that the "Test pattern" button works correctly.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt