]> git.koha-community.org Git - koha.git/commit
Bug 11341: fix XSS bug in opac-search.pl (facets)
authorChris Cormack <chrisc@catalyst.net.nz>
Wed, 4 Dec 2013 21:09:20 +0000 (10:09 +1300)
committerGalen Charlton <gmc@esilibrary.com>
Wed, 4 Dec 2013 21:59:18 +0000 (21:59 +0000)
commitd2d365ca830345b9a519158f6d735d2abd125380
treed5e82e5aab859f24b81dc242c294657effc973d2
parent1b695517a6b98720ee300ba21280ee2f8139a796
Bug 11341: fix XSS bug in opac-search.pl (facets)

This patch fixes the prog theme; the bootstrap theme already
does the necessary filtering.

To test
1/ Craft a url like
 cgi-bin/koha/opac-search.pl?idx=kw&q=fish&offset=20" onmouseover%3dprompt(994000) bad%3d"
 (the search must return enough results to have a show more link in the facets)

2/ Check the source, or mouseover the Show more links in the facets
   Notice the code is executable

3/ Apply patch - notice it is no longer executable

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc