]> git.koha-community.org Git - koha.git/log
koha.git
12 years agoFix for Bug 7006, highlight patron changes in email
Owen Leonard [Tue, 11 Oct 2011 19:56:10 +0000 (15:56 -0400)]
Fix for Bug 7006, highlight patron changes in email

This patch eliminates all unchanged fields from the email
on the assumption that the information is superfluous. I have
also added a link to the patron edit screen which will be
displayed if the staffClientBaseURL has been entered.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7247 - rebuild_zebra.pl -v should show all Zebra log output
Dobrica Pavlinusic [Sat, 19 Nov 2011 10:49:53 +0000 (11:49 +0100)]
Bug 7247 - rebuild_zebra.pl -v should show all Zebra log output

Currently, -v option resets Zebra log output to default system values.

This produce amount of log specified in system defaults which is usually
too low for debugging.

This change explicitly forces all Zebra log output which create much more
chatter so it triggers with verbosity level 2

Test scenario:
1. pick koha site to reindex
2. use -v -v options to rebuild_zebra.pl to see additional output

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Verified help corrections and  loglevel 2 output vs. loglevel 1 output. No issues found.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6466 - hung socket read causes SIP tests to fail
JAMES Mason [Mon, 6 Jun 2011 04:10:39 +0000 (16:10 +1200)]
Bug 6466 - hung socket read causes SIP tests to fail

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7357: display serial title instead of '---'
Adrien Saurat [Mon, 9 Jan 2012 10:55:08 +0000 (11:55 +0100)]
Bug 7357: display serial title instead of '---'

The full title of a serial is now displayed even
if several lines have the same title.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_5533'
Paul Poulain [Tue, 17 Jan 2012 15:03:14 +0000 (16:03 +0100)]
Merge remote-tracking branch 'origin/new/bug_5533'

12 years agoBug 5533 followup: reinstate Lost status editing
Ian Walls [Thu, 15 Dec 2011 13:21:56 +0000 (08:21 -0500)]
Bug 5533 followup: reinstate Lost status editing

The original patch for 5533 removed the Lost status from the edit items screen; new items were not affected,
and batch changes could still be made, so this was not a consistent change.

This patch removes the filter that hid the Lost status dropdown, but then changes the default MARC framework
to hide this field by default (value -5).  New installations will not see this status in the editor, unless
they manually activate it.  This will enforce the semantics of using the "mark lost" options by default, but
provide a workaround for libraries that understand and accept the consequences of manually editing this field.

To test:

1.  on an existing install, edit an item.  you should have the Lost status visible
2.  on a new install, editing or creating an item should not show the Lost status at all

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7407: HidePatronName not working on 'on hold for' messages
Ian Walls [Thu, 5 Jan 2012 19:10:52 +0000 (14:10 -0500)]
Bug 7407: HidePatronName not working on 'on hold for' messages

HidePatronName was not working on 'on hold for' messages, only 'checked out to'
messages.  This resulted in the patrons name showing if the item was on hold for
them.

T:T scope issue; needs to be within itemloo.  This patch does that.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_5327'
Paul Poulain [Tue, 17 Jan 2012 14:35:19 +0000 (15:35 +0100)]
Merge remote-tracking branch 'origin/new/bug_5327'

12 years agobug 5327 add tests for C4/BackgroundJob.pm
Sam Sanders [Tue, 17 Jan 2012 02:37:59 +0000 (15:37 +1300)]
bug 5327 add tests for C4/BackgroundJob.pm

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
perl t/db_dependent/BackgroundJob.t
All tests complete successfully.

Note: Test 11 does not tell what it's about, but it has been there before.

12 years agoBug 5327 Added unit tests for C4/Reports.pm
Connor Dewar [Tue, 17 Jan 2012 02:40:25 +0000 (15:40 +1300)]
Bug 5327 Added unit tests for C4/Reports.pm

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
perl t/Reports.t b/t/Reports.t
All tests complete successfully.

12 years agoBug 5327 Added unit tests for C4/ClassSortRoutine/Dewey.pm
Connor Dewar [Tue, 17 Jan 2012 01:32:29 +0000 (14:32 +1300)]
Bug 5327 Added unit tests for C4/ClassSortRoutine/Dewey.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 5327 added unit tests for C4/ClassSortRoutine/Generic
Connor Dewar [Tue, 17 Jan 2012 00:55:03 +0000 (13:55 +1300)]
Bug 5327 added unit tests for C4/ClassSortRoutine/Generic

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoMerge remote-tracking branch 'origin/new/bug_6990'
Paul Poulain [Tue, 17 Jan 2012 14:07:09 +0000 (15:07 +0100)]
Merge remote-tracking branch 'origin/new/bug_6990'

12 years agoBug 6990 follow up PODDOC & unit test updating
Paul Poulain [Mon, 16 Jan 2012 17:47:15 +0000 (18:47 +0100)]
Bug 6990 follow up PODDOC & unit test updating

This patch removes the TransformKohaToMarcOneField sub, but there was some remaining POD & unit test about it

12 years agoTransformKohaToMarc enhancement
Frédéric Demians [Sat, 8 Oct 2011 15:03:18 +0000 (17:03 +0200)]
TransformKohaToMarc enhancement

TransformKohaToMarc function is called for each biblio and item that has
to be build. This function execute a DB statement for each Koha field
that has to be mapped to a MARC tag/letter. This impact deeply
performances for script like rebuild_zebra, especially since items are
not anymore in bilio records and have to be rebuild on the fly.

I'm proposing a patch which read Koha field to MARC field mapping just
one time and cache it. My test show a 30% execution time improvement on
rebuild_zebra.pl script. It uses already cached mapping in C4::Context.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
http://bugs.koha-community.org/show_bug.cgi?id=6990
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7364'
Paul Poulain [Tue, 17 Jan 2012 11:05:00 +0000 (12:05 +0100)]
Merge remote-tracking branch 'origin/new/bug_7364'

Conflicts:
cataloguing/additem.pl

12 years agoBug 7364: Possible to get to FA item add without current branch being defined.
D Ruth Bavousett [Fri, 16 Dec 2011 15:38:47 +0000 (10:38 -0500)]
Bug 7364: Possible to get to FA item add without current branch being defined.

Some paths to the FA item-add screen didn't have a branch defined--if the param is set,
use it, otherwise, use the user's logged in branch.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Modified for syntax by:  Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
12 years agoRevert "Bug 7364: Possible to get to FA item add without current branch being defined."
Paul Poulain [Tue, 17 Jan 2012 08:32:21 +0000 (09:32 +0100)]
Revert "Bug 7364: Possible to get to FA item add without current branch being defined."

This reverts commit 6f681bec2d71d3d2b88aea5f8e0c15010241d580.

12 years agoRevert "Bug 7364: Possible to get to FA item add without current branch being defined."
Paul Poulain [Mon, 16 Jan 2012 17:58:10 +0000 (18:58 +0100)]
Revert "Bug 7364: Possible to get to FA item add without current branch being defined."

This reverts commit 6f681bec2d71d3d2b88aea5f8e0c15010241d580.

Reverting because on my test server, I get

syntax error at /home/paul/koha.dev/koha-community/cataloguing/additem.pl line
668, near "->param{"
Execution of /home/paul/koha.dev/koha-community/cataloguing/additem.pl aborted
due to compilation errors.

12 years agoMerge remote-tracking branch 'origin/new/bug_929'
Paul Poulain [Mon, 16 Jan 2012 17:19:38 +0000 (18:19 +0100)]
Merge remote-tracking branch 'origin/new/bug_929'

12 years agoBug 929 : Follow up to allow tests to check plugins too
Chris Cormack [Fri, 13 Jan 2012 18:28:11 +0000 (07:28 +1300)]
Bug 929 : Follow up to allow tests to check plugins too

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
perl xt/author/valid-templates.t runs without errors now.

12 years agoBug 7364: Possible to get to FA item add without current branch being defined.
D Ruth Bavousett [Fri, 16 Dec 2011 15:38:47 +0000 (10:38 -0500)]
Bug 7364: Possible to get to FA item add without current branch being defined.

Some paths to the FA item-add screen didn't have a branch defined--if the param is set,
use it, otherwise, use the user's logged in branch.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7143'
Paul Poulain [Mon, 16 Jan 2012 14:05:49 +0000 (15:05 +0100)]
Merge remote-tracking branch 'origin/new/bug_7143'

12 years agoBug 7143: add Albert Oller to the about.tt
Jesse Maseto [Fri, 13 Jan 2012 23:34:00 +0000 (18:34 -0500)]
Bug 7143: add Albert Oller to the about.tt

Albert Oller was in the doc/history.txt but not the About page.
adding him alphabetically

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6947 : opac-topissues.pl wasn't respecting item live itemtypes
Chris Cormack [Fri, 28 Oct 2011 19:49:20 +0000 (08:49 +1300)]
Bug 6947 : opac-topissues.pl wasn't respecting item live itemtypes

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
The search was only looking for bib level itypes independent
from the settings for item-level_itypes.

After patch the system preference setting is respected
and search works accordingly.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_6132'
Paul Poulain [Mon, 16 Jan 2012 13:53:08 +0000 (14:53 +0100)]
Merge remote-tracking branch 'origin/new/bug_6132'

12 years agoBug 6132: Add unit test for system preferences
Julian Maurice [Mon, 2 Jan 2012 09:49:28 +0000 (10:49 +0100)]
Bug 6132: Add unit test for system preferences

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6132: Update sysprefs cache in set_preference
Julian Maurice [Mon, 2 Jan 2012 09:45:55 +0000 (10:45 +0100)]
Bug 6132: Update sysprefs cache in set_preference

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
12 years agoMerge remote-tracking branch 'origin/new/bug_929'
Paul Poulain [Fri, 13 Jan 2012 16:47:30 +0000 (17:47 +0100)]
Merge remote-tracking branch 'origin/new/bug_929'

12 years agoBug 929 small follow-up (mistake in POD)
Paul Poulain [Fri, 13 Jan 2012 16:47:16 +0000 (17:47 +0100)]
Bug 929 small follow-up (mistake in POD)

12 years agoBug 929 : Follow up adding unit tests, discovered C4::Dates cached the syspref with...
Chris Cormack [Thu, 12 Jan 2012 08:23:21 +0000 (21:23 +1300)]
Bug 929 : Follow up adding unit tests, discovered C4::Dates cached the syspref with no way to clear it, fixed also.

12 years agoBug 929: Follow up adding the Koha:: namespace to the list of modules to test
Chris Cormack [Thu, 12 Jan 2012 07:16:52 +0000 (20:16 +1300)]
Bug 929: Follow up adding the Koha:: namespace to the list of modules to test

12 years agoBug 7240: Cleaning up import tables and action_logs
Marcel de Rooy [Mon, 21 Nov 2011 11:21:11 +0000 (12:21 +0100)]
Bug 7240: Cleaning up import tables and action_logs

This patch lets cleanup_database also purge older records from the (five) import tables and the action_logs table.
Two new command line parameters are introduced: --import and --logs.
If no number of days is specified for --zebraqueue, --import or --logs, it defaults to 30 days, 60 days resp. 180 days.
I did not add a default for --sessdays, because this parameter cannot be seen separately from parameter --sessions.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Adds new parameters and code, does not change existing behaviour

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7396: Debarred message not showing over SIP2
Ian Walls [Mon, 2 Jan 2012 16:06:13 +0000 (11:06 -0500)]
Bug 7396: Debarred message not showing over SIP2

Corrects typo in list of flags; was DEBARRED, but the actual name of the flag is
DBARRED (for some reason)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7381 - wrong isbn showing on the staff search results
Owen Leonard [Tue, 27 Dec 2011 19:46:54 +0000 (14:46 -0500)]
Bug 7381 - wrong isbn showing on the staff search results

Outputting the "raw" ISBN. In the case of multiples, ISBNs
are concatenated with " | " Using a T:T filter to make these
a comma-separated list.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Added a record and confirmed that the right ISBN shows on the
search results and that the amazon cover image still works.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7363: allows downloading of lists in CSV format
Adrien Saurat [Fri, 16 Dec 2011 15:51:18 +0000 (16:51 +0100)]
Bug 7363: allows downloading of lists in CSV format

Getting a list in CSV format was impossible because the
shelfid parameter was empty in the URL.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7360 Import Default framework into other deletes default Framework
Admin User Koha [Wed, 14 Dec 2011 16:31:00 +0000 (17:31 +0100)]
Bug 7360 Import Default framework into other deletes default Framework

Step to reproduce :
- export default framework as SQL
- create new framework
- Import the exported SQL file into this new framework.
Go to default framework :
It disappeared.

If some libraries want to share default frameworks, then it is a major bug.
This patch fixes the test in order to cope with 0 character framework name.

Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7356 - Fix various typos and mis-spellings
Marc Balmer [Sun, 11 Dec 2011 18:00:14 +0000 (19:00 +0100)]
Bug 7356 - Fix various typos and mis-spellings

Fix typos: the the -> the, wether -> whether, developper -> developer.

http://bugs.koha-community.org/show_bug.cgi?id=7356
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_6716'
Paul Poulain [Fri, 13 Jan 2012 10:46:21 +0000 (11:46 +0100)]
Merge remote-tracking branch 'origin/new/bug_6716'

12 years ago6717 Documenting need_merge_authorities table
Marcel de Rooy [Thu, 20 Oct 2011 07:25:23 +0000 (09:25 +0200)]
6717 Documenting need_merge_authorities table

Documentation only.

http://bugs.koha-community.org/show_bug.cgi?id=6716
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agobug6716 - document the aqbooksellers table
Nicole C. Engard [Wed, 28 Sep 2011 12:05:29 +0000 (08:05 -0400)]
bug6716 - document the aqbooksellers table

This documents the table that stores vendor info in Koha.

There were 4 unused fields found:
  `accountnumber`
  `othersupplier`
  `currency`
  `booksellerurl`

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Accountnumber is no longer unused and can be managed.

12 years agoBug 7348 - Fixed error for serial toolbar buttons in IE7
Duncan Tyler [Tue, 13 Dec 2011 03:42:17 +0000 (16:42 +1300)]
Bug 7348 - Fixed error for serial toolbar buttons in IE7

http://bugs.koha-community.org/show_bug.cgi?id=7348
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7375 - Update minimum version of Perl to 5.10
Magnus Enger [Thu, 22 Dec 2011 09:20:44 +0000 (10:20 +0100)]
Bug 7375 - Update minimum version of Perl to 5.10

- Change the installer script to look for at least 5.10/5.010000
- Change the template to ask for the correct version

To test:
- Run through the webinstaller on 5.10 or newer and check that there are
no errors.
- Ideally: Run through the webinstaller on an older version than 5.10 and
check that there *is* an error, asking for 5.10 or newer.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7373 - Add 5 new icons to Bridge Set
Nicole C. Engard [Fri, 16 Dec 2011 11:17:09 +0000 (06:17 -0500)]
Bug 7373 - Add 5 new icons to Bridge Set

This patch adds 5 new icons to the Bridge Set.
These icons are designed by the Erikson Institute
in Chicago, IL, USA.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7368: Correct spelling of merge authorities job in pref file.
Marcel de Rooy [Mon, 19 Dec 2011 12:46:31 +0000 (13:46 +0100)]
Bug 7368: Correct spelling of merge authorities job in pref file.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7367: Add space before display of languages.
Marcel de Rooy [Mon, 19 Dec 2011 12:25:42 +0000 (13:25 +0100)]
Bug 7367: Add space before display of languages.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I am a bit confused why it does not work without the &nbsp;
but patch fixes the display problem.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5226: Add 545 to es-ES and nb-NO
Jared Camins-Esakov [Mon, 9 Jan 2012 14:31:07 +0000 (09:31 -0500)]
Bug 5226: Add 545 to es-ES and nb-NO

Since the original patches for bug 5226 were submitted, two new translations
have been added to Koha: es-ES and nb-NO. This patch adds the missing 545 line
to the frameworks for those languages.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5226: Follow up to new/awaiting_qa/bug_5226
Katrin Fischer [Mon, 6 Dec 2010 17:39:38 +0000 (18:39 +0100)]
Bug 5226: Follow up to new/awaiting_qa/bug_5226

This patch adds the field definition to
- it-IT (default and sample frameworks)
- de-DE, en, fr-FR, pl-PL (sample frameworks)

I am not sure about the database update. If we want to do that, it should perhaps update all frameworks and languages.
At the moment only en and de-DE default frameworks are updated.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoAdd MARC21 field 545 to to framework fix bug 5226
Jared Camins-Esakov [Tue, 2 Nov 2010 03:08:24 +0000 (23:08 -0400)]
Add MARC21 field 545 to to framework fix bug 5226

Adds MARC21 field 545 to the English, French, German, and Polish MARC21
frameworks. The labels for the field still need to be translated into
French and Polish.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 6098 Followup -- doesn't replace NSB/NSE by space
Frédéric Demians [Fri, 13 May 2011 13:24:39 +0000 (15:24 +0200)]
Bug 6098 Followup -- doesn't replace NSB/NSE by space

On any page, NSB/NSE characters are replaced by space in Output.pm. It isn't a
good thing:

  - It isn't necessary since Zebra indexer handle properly those characters as
    delimiter.
  - It isn't necessary for display since XSL file already do that.
  - It isn't efficient since a regex is done on every whole page sent by Koha,
    not only on biblio record part.
  - It removes an information that librarian want to keep in their biblio
    records: any record edited in Koha loose its NSB/NSE characters.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBUG 6098 zebra conf NSB NSE indexed as space
Fridolyn SOMERS [Wed, 6 Apr 2011 15:44:52 +0000 (17:44 +0200)]
BUG 6098 zebra conf NSB NSE indexed as space

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 5358: Show cancelled orders in basket page
Julian Maurice [Sat, 5 Nov 2011 09:35:48 +0000 (15:05 +0530)]
Bug 5358: Show cancelled orders in basket page

Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_2629'
Paul Poulain [Tue, 10 Jan 2012 22:35:48 +0000 (23:35 +0100)]
Merge remote-tracking branch 'origin/new/bug_2629'

12 years agoBug 2629 - Diacritics not being ignored when searching
Albert Oller [Wed, 30 Nov 2011 00:16:51 +0000 (19:16 -0500)]
Bug 2629 - Diacritics not being ignored when searching

/etc/zebradb/etc/word-phrase-utf.chr
added Cc miniscule and Cc circumflex; added Kk acute accent.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
- imported marc record from the bug with the offending diacritic
- reindexed
- searched for the title - result found! Yay!

12 years agoBug 5543 - Date ISO format wrong separator
Owen Leonard [Wed, 7 Dec 2011 17:18:53 +0000 (12:18 -0500)]
Bug 5543 - Date ISO format wrong separator

This patch converts the changes in Fridolyn SOMERS patch
to T:T and adds an update to the database to correct
the description there.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7278 follow-up DBrev number
Paul Poulain [Tue, 10 Jan 2012 22:00:04 +0000 (23:00 +0100)]
Bug 7278 follow-up DBrev number

12 years agoBug 7278: Follow up fixing display of item informaton on detail page
Katrin Fischer [Tue, 20 Dec 2011 07:40:03 +0000 (08:40 +0100)]
Bug 7278: Follow up fixing display of item informaton on detail page

Fixes a display problem in the item table on staff detail page.

To test:
Add a record with 3 items:
- 1 with copynumber
- 1 with materials specified
- 1 with opac notes

Before patch the table will be broken a bit and the headings
don't match the contents (wrong sequence).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7278 : Additional Materials
Chris Cormack [Thu, 1 Dec 2011 01:19:44 +0000 (14:19 +1300)]
Bug 7278 : Additional Materials

Part 2: This patch shows the message at checkout and checkin

How to test:
* Add a note in cataloguing
* Check it displays at checkout and checkin
* Check items without a note don't display anything

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 7728 : Materials Specified field made larger and displayed
Chris Cormack [Wed, 30 Nov 2011 21:46:52 +0000 (10:46 +1300)]
Bug 7728 : Materials Specified field made larger and displayed

This first page makes the database change, and displays the field on
the detail.pl and moredetail.pl pages in the staff client

How to Test:

* Add a note to the materials specified page in cataloguing (952
subfield 3 for MARC21, but it shouldn't matter as long as you have a
field mapped to items.materials
* Check it displays at catalogue/detail.pl
* Check it displays at catalogue/moredetail.pl

Patch to follow to have the note display at checkin/checkout

http://bugs.koha-community.org/show_bug.cgi?id=7278

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed conflicts in updatedatabase.pl and kohastructure.sql

12 years agoBug 7077, follow-up
Paul Poulain [Fri, 6 Jan 2012 16:45:02 +0000 (17:45 +0100)]
Bug 7077, follow-up

* DBrev number
* added a small text to the text displayed when upgrading (3.6 behaviour & before 3.6 behaviour)

12 years agoFix for Bug 7077 - Add system pref to control behavior of submitting empty barcode...
Owen Leonard [Fri, 21 Oct 2011 19:04:53 +0000 (15:04 -0400)]
Fix for Bug 7077 - Add system pref to control behavior of submitting empty barcode field

Adds a new system preference, CircAutoPrintQuickSlip:

When an empty an empty barcode field is submitted in circulation
[ clear the screen | open a print quick slip window ].

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Fixed a merge conflict with the updatedatabase.pl

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Another merge conflict resolved. Marked as Passed QA.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6190: BorrowerUnwantedField syspref and removing fields from the patron entry
Srdjan Jankovic [Mon, 10 Oct 2011 00:12:27 +0000 (13:12 +1300)]
Bug 6190: BorrowerUnwantedField syspref and removing fields from the patron entry

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested with example from bug and by deleting parts of it:
cardnumber|surname|firstname|title|othernames|initials|streetnumber|streettype|address|address2|city|state|zipcode|country|email|phone|mobile|fax|emailpro|phonepro|B_streetnumber|B_streettype|B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_email|B_phone|dateofbirth|branchcode|categorycode|dateenrolled|dateexpiry|gonenoaddress|lost|debarred|contactname|contactfirstname|contacttitle|borrowernotes|relationship|sex|password|userid|opacnote|contactnote|sort1|sort2|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone

Note: This only affects the edit screen, not the patron detail tab.
A nice enhancement would be to make this page follow the system preference too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA comments on Bugzilla. Passing QA.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
* DBrev defined
* small improvement suggested by Marcel added = there is now a link to the schema page on the systempreference

12 years agoBug 6374: default value for Size in result pages
Adrien Saurat [Tue, 3 Jan 2012 14:28:50 +0000 (15:28 +0100)]
Bug 6374: default value for Size in result pages

When no size info is available, an empty string is
sent to the TT (if nothing is sent, the TT engine
will display another information, irrelevant for Koha).

Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com>
Works beautifully!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 3651 Follow-up, Require patron login to send shelves and baskets
Owen Leonard [Thu, 29 Dec 2011 16:47:44 +0000 (11:47 -0500)]
Bug 3651 Follow-up, Require patron login to send shelves and baskets

The fix for Bug 4289, "Add a syspref 'OpacPublic', to hide OPAC
search-bar and force authentication on all OPAC pages" incorrectly
made some page permissions dependent on the value of the OpacPublic
setting. Some pages should require authentication no matter what.

This patch returns opac-sendbasket.pl to the state it was in before
Bug 4289, Bug 4274 notwithstanding. I have added the authentication
requirement to opac-sendshelf.pl to match.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
1) sending cart requires login
2) sending shelf requires login
3) updating personal details requires login

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7220 - Add IDs to check-in message dialogs to facilitate CSS customization
Chris Hall [Thu, 22 Dec 2011 02:43:08 +0000 (15:43 +1300)]
Bug 7220 - Add IDs to check-in message dialogs to facilitate CSS customization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoFix for Bug 7194 - OPAC detail and recent comments pages corrections for XHTML validity
Owen Leonard [Tue, 8 Nov 2011 16:43:38 +0000 (11:43 -0500)]
Fix for Bug 7194 - OPAC detail and recent comments pages corrections for XHTML validity

- Adding html filter to subtitle output to correct unescaped ampersands
- Adding missing alt attributes to libravatar output
- Removing unecessary markup  from comments page

Bonus: Adding html_break filter to output of comments to preserve line breaks
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoFix to make date obviously editable - bug 7193
Duncan Tyler [Mon, 19 Dec 2011 00:43:21 +0000 (13:43 +1300)]
Fix to make date obviously editable - bug 7193

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch changes all date fields on subscription entry to be
obvious input fields. This makes it more obvious that you
can enter dates manually and is more consistent with how
we handle dates in other places.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7341 - [SIGNED-OFF] Patch to fix error produced when clicking cancel in system...
Duncan Tyler [Thu, 22 Dec 2011 01:32:22 +0000 (14:32 +1300)]
Bug 7341 - [SIGNED-OFF] Patch to fix error produced when clicking cancel in system preferences search results - bug 7341

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7338: Follow up: show link only when there is more than 1 subscription
Katrin Fischer [Mon, 12 Dec 2011 07:39:39 +0000 (08:39 +0100)]
Bug 7338: Follow up: show link only when there is more than 1 subscription

To be tested together with
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6690

1) Create a subscription for a title
- check the link 'Show any subscription...' doesn't show now
- check the serials collection page works correctly and shows all
necessary information

2) Create a second subscription for the same title
- check a new link 'Show any subscription...' shows up now
- use links in the issue table to change between viewing the single subscription
and the overview page
- check it works correctly and all information shows up

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
It works. With this patch, on Serials Collection page, the link, 'See any
subscription attached to this biblio' appears only when there are more than one
subscription attached to the biblio record.

12 years agoBug 7338 Links on Serial Collection page
Frédéric Demians [Fri, 9 Dec 2011 07:32:01 +0000 (08:32 +0100)]
Bug 7338 Links on Serial Collection page

Don't display link to the serial, when the collection page displays just
one subscription. Display it when several subscriptions. Alway display a
link for displaying biblio record other subscriptions.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch works nicely, but always shows link to 'any subscriptions'.
I did a follow-up so the link would only show if there was more
than 1 subscription for the record.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until...
Owen Leonard [Thu, 8 Dec 2011 15:22:07 +0000 (10:22 -0500)]
Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year 9999

This patch copies the debarred handling method from circulation.pl for
use on opac-user.pl so that debarred dates and comments can be handled
properly.

I have slightly reworded the message in the OPAC and on circulation.pl
to make the display of the debarred comment a little clearer.

Revision adds missing handling of debarred status with regard to
renewal operations. Renew links and buttons were not being hidden
from debarred users.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Renewal buttons are gone, message looks good.

liz@koha-deb:~/kohaclone$ prove xt
xt/permissions.t .. ok
xt/tt_valid.t ..... ok
All tests successful.
Files=2, Tests=27,  9 wallclock secs ( 0.05 usr  0.01 sys +  8.28 cusr  0.08 csys =  8.42 CPU)
Result: PASS

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7337 - Followup - Correcting instances of "debar" that crept back in.
Liz Rea [Thu, 8 Dec 2011 16:21:07 +0000 (10:21 -0600)]
Bug 7337 - Followup - Correcting instances of "debar" that crept back in.

To test:
Restrict one of your patrons -
Make sure that on memberentrygen.tt (Edit Patron) the radio button label says "Restricted"
Make sure that on moremember.tt (Patron detail) the button to lift debarment says "Restricted"

12 years agoBug 6147 : Correcting invalid RSS
Christophe Croullebois [Mon, 16 May 2011 22:16:07 +0000 (10:16 +1200)]
Bug 6147 : Correcting invalid RSS

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Feed validates using http://feed1.w3.org/ with the following recommendations:

This feed is valid, but interoperability with the widest range of feed readers could be improved by implementing the following recommendations.
line 12, column 149: Relative href value on self link: /cgi-bin/koha/opac-search.pl?idx=kw&q=some&sort_by=acqdate_dsc&format=rss2 [help]
... p;sort_by=acqdate_dsc&amp;format=rss2"/>
                                             ^
line 12, column 149: Self reference doesn't match document location [help]
... p;sort_by=acqdate_dsc&amp;format=rss2"/>
                                             ^
line 20, column 158: Unregistered link relationship: search (10 occurrences) [help]
... _by=&amp;format=opensearchdescription"/>
                                             ^
line 40, column 9: description should not contain relative URL references: /cgi-bin/koha/opac-reserve.pl?biblionumber=10 (10 occurrences) [help]
]]></description>
         ^
line 22, column 5: Misplaced Item (9 occurrences) [help]
     <item>

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6627 follow-up
Paul Poulain [Fri, 6 Jan 2012 13:22:59 +0000 (14:22 +0100)]
Bug 6627 follow-up

in installer, some lines where forgotten, and can also be commented

12 years agoBug 6627 [Signed Off] - Update to improve security in specified log files - bug 6627
Duncan Tyler [Wed, 21 Dec 2011 01:59:21 +0000 (14:59 +1300)]
Bug 6627 [Signed Off] - Update to improve security in specified log files - bug 6627

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Verified sessionlog file is not written to /tmp when patch is applied. Also verified original bug - logging in did in fact log to /tmp.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5369: Follow up fixing quotes
Katrin Fischer [Thu, 5 Jan 2012 07:09:03 +0000 (08:09 +0100)]
Bug 5369: Follow up fixing quotes

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Confirm that this works. My only remark would be that &quot; could have been used.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5369: Make series tracings use phrase indexes
Jared Camins-Esakov [Fri, 2 Dec 2011 00:35:43 +0000 (19:35 -0500)]
Bug 5369: Make series tracings use phrase indexes

By definition, series tracings should search for other records in the same
series, i.e., those with the exact same series title. This patch forces the
tracings to use phrase indexes for series tracings.

Note that this patch DOES NOT respect TraceCompleteSubfields. While that may be
desirable, it is outside the scope of the current patch. An additional follow-up
patch could be written to add support for TraceCompleteSubfields, if community
concensus is that series tracings should obey TraceCompleteSubfields.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Thx for the follow up and sign off Jared :)

12 years agoBug 5369: se queries with paranthesis fail
Katrin Fischer [Mon, 28 Nov 2011 06:25:37 +0000 (07:25 +0100)]
Bug 5369: se queries with paranthesis fail

This patch does several things to make the search work better:

1) Adding "" around search terms for queries on index se.
2) Make links for 8xx obey the UseControlNumber system preference
3) Fix the indexing for 8xx fields, as they were not included in the se index before

Note: Make sure you copy the new record.abs into your koha-dev directory and reindex
before testing.

To test:
1) Add records using the following fields:
440$a
490$a ind. 1 = empty or 0
490$a ind. 1 = 1
800$a, 810$a, 811$a or 830$a

Example value taken form bug description, should only work after applying the patch:
DHEW publication no. (HSM) 73-1804

Please also test with other examples.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 929: Follow up - showing fund code instead of internal number
Katrin Fischer [Thu, 29 Dec 2011 09:51:15 +0000 (10:51 +0100)]
Bug 929: Follow up - showing fund code instead of internal number

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 929 : Followup fixing date formatting
Chris Cormack [Thu, 29 Dec 2011 08:46:51 +0000 (21:46 +1300)]
Bug 929 : Followup fixing date formatting

This patch introduces a Filter (KohaDates) for use in templates
[% USE KohaDates %]
[% somevariable | $KohaDates %]

This will format the date in the format specified by the systempreference

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 929 : Last follow up, implementing the last of Katrins suggestions
Chris Cormack [Wed, 28 Dec 2011 20:08:40 +0000 (09:08 +1300)]
Bug 929 : Last follow up, implementing the last of Katrins suggestions

Date formatting
Links
Nomenclature changes

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 929 : Follow up, making some improvements to the spent page More to come
Chris Cormack [Wed, 28 Dec 2011 02:43:47 +0000 (15:43 +1300)]
Bug 929 : Follow up, making some improvements to the spent page More to come

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 929 : Reinstating the breakdown of budgets
Chris Cormack [Tue, 27 Dec 2011 20:47:56 +0000 (09:47 +1300)]
Bug 929 : Reinstating the breakdown of budgets

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 3184: Show creator and budget on order receive page
Katrin Fischer [Fri, 28 Oct 2011 13:54:53 +0000 (15:54 +0200)]
Bug 3184: Show creator and budget on order receive page

Reimplementing 3.0.x patch from
Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>

To test:
1) Create basket
2) Order something, note your fund
3) Receive title
> Verify your name and selected fund display correctly

Additional tests:
1) Set borrowernumber in aqbasket.authorisedby to a nonexistant borrowernumber (like something really big)
> Created by should show "No name"
2) Set borrowernumber to NULL / empty
> Created by should show "No name"

Signed-off-by: Duncan Tyler <duncan@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7394 : Fixing scoping issue with XSLT processing. Also bailing out early for...
Chris Cormack [Tue, 3 Jan 2012 06:57:41 +0000 (19:57 +1300)]
Bug 7394 : Fixing scoping issue with XSLT processing. Also bailing out early for 404 inestead of doing unnessecary processing

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
I can confirm the bug and the solution.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Second sign-off from me, patch fixes display of detail page
for last record on a result page.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_6880'
Paul Poulain [Fri, 6 Jan 2012 10:03:25 +0000 (11:03 +0100)]
Merge remote-tracking branch 'origin/new/bug_6880'

Conflicts:
kohaversion.pl

12 years agofollow-up for DB rev number
Paul Poulain [Fri, 6 Jan 2012 10:00:43 +0000 (11:00 +0100)]
follow-up for DB rev number

I should not have used 3.6 (see mail on koha-devel)

12 years agoMerge remote-tracking branch 'origin/new/bug_6530'
Paul Poulain [Fri, 6 Jan 2012 09:59:05 +0000 (10:59 +0100)]
Merge remote-tracking branch 'origin/new/bug_6530'

Conflicts:
kohaversion.pl

12 years agofollow-up: fixing DBrev wrong number
Paul Poulain [Fri, 6 Jan 2012 09:58:08 +0000 (10:58 +0100)]
follow-up: fixing DBrev wrong number

I should not have used 3.06 (see mail on koha-devel)

12 years agoMerge remote-tracking branch 'origin/new/bug_6328'
Paul Poulain [Fri, 6 Jan 2012 09:52:47 +0000 (10:52 +0100)]
Merge remote-tracking branch 'origin/new/bug_6328'

Conflicts:
kohaversion.pl

12 years agofollow-up of the previous follow-up: forgot the kohaversion.pl file
Paul Poulain [Fri, 6 Jan 2012 09:51:42 +0000 (10:51 +0100)]
follow-up of the previous follow-up: forgot the kohaversion.pl file

12 years agofollow-up: fixing mistake in database revision number
Paul Poulain [Fri, 6 Jan 2012 09:50:48 +0000 (10:50 +0100)]
follow-up: fixing mistake in database revision number

After long discussion with chris_c (previous RM) and chris_n (previous and actual RMaint), it appears I should not have used 3.06
chris_n will duplicate this entry if it's needed to port this patch onto master.

I renumber the version to 3.07

I also have found in my testings that there is a problem if this DBrev is run twice (once in 3.6 and once in 3.8)
All patrons that are temporarily suspended (ie: have a date in debarred) will become suspended forever
The test was just made on debarred<>0, it's OK if we come from a 3.4, as debarred is a tinyint used as a boolean.
But if we already have a date, it won't do what we want.
I switched to a =1 instead of <>0, that fixes the problem

12 years agoBug 7328 Expanded options in advanced search
Frédéric Demians [Wed, 7 Dec 2011 07:46:21 +0000 (08:46 +0100)]
Bug 7328 Expanded options in advanced search

In OPAC and intra advanced search, more search options are displayed
depending on expandedSearchOption syspres and user choice. This doesn't
work anymore in HEAD.

This patch restore this functionnality.

To test:

  - enable/disable expandedSearchOption.
  - Load advanced search page. Limited seach options version is always
    displayed
  - Apply this patch and see how it works...

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
The problem only appeared in the staff client for me.
Tested both OPAC and staff with patch applied.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7333 - Fixing up db_dependent/Search.t to use sample data Thanks to Chris N....
Liz Rea [Thu, 15 Dec 2011 16:21:36 +0000 (10:21 -0600)]
Bug 7333 - Fixing up db_dependent/Search.t to use sample data Thanks to Chris N. for helping figure out that it was because there were no French stopwords in the DB that the test was failing.

Patch changes the French string (with French stopwords) to an English string with English stopwords, as only English stopwords are installed in the default data.

This patch will allow Search.t to run on the database attached to this bug.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug #6142 - Delete sub CanBookBeReserved and delete function's reference on @EXPORT
Alex Arnaud [Fri, 8 Apr 2011 12:02:19 +0000 (14:02 +0200)]
Bug #6142 - Delete sub CanBookBeReserved and delete function's reference on @EXPORT

Original-Author:    Alex Arnaud <alex.arnaud@biblibre.com>, Stéphane Delaune <stephane.delaune@biblibre.com>
Original-Signed-off-by: MJ Ray <mjr@phonecoop.coop>
Correct use statement bug found by Ian Walls

Author: MJ Ray <mjr@phonecoop.coop>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5729 - Add CoinS to intranet
Paul Poulain [Tue, 27 Sep 2011 16:35:33 +0000 (18:35 +0200)]
Bug 5729 - Add CoinS to intranet

This patch adds CoinS support to biblio displays in staff interface.
librarians can now use zotero on the staff interface

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Modified by: Ian Walls <ian.walls@bywatersolutions.com>

GetCOinSBiblio has changed interface, requiring a $record object instead
of looking one up by biblionumber.  Calls in ISBDdetail.pl, MARCdetail.pl
and detail.pl updated.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
12 years agoBUG 5607 : Adds parsing of issues fields in overdue letters
Sophie Meynieux [Mon, 19 Dec 2011 11:31:21 +0000 (12:31 +0100)]
BUG 5607 : Adds parsing of issues fields in overdue letters

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch makes it possible to add fields from the issues table to overdue notices.

Template used for testing:
<item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> , Checkout date: <<issues.issuedate>>, Due date: <<issues.date_due>> Fine: <fine>GBP</fine> Checkout date from items: <<items.onloan>></item>

Possible improvements:
- Dates are not formatted according to dateformat system preference

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5565 UNIMARC to DC XSL tidy up
Frédéric Demians [Fri, 31 Dec 2010 06:35:29 +0000 (07:35 +0100)]
Bug 5565 UNIMARC to DC XSL tidy up

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5565 Default OAI UNIMARC to Dublin Core XSL adds superfluous blanks
Frédéric Demians [Fri, 31 Dec 2010 06:32:41 +0000 (07:32 +0100)]
Bug 5565 Default OAI UNIMARC to Dublin Core XSL adds superfluous blanks

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 1623 - Provide view of approved comments
Owen Leonard [Mon, 28 Nov 2011 13:35:21 +0000 (08:35 -0500)]
Bug 1623 - Provide view of approved comments

This patch creates two tabs on the comments administration page:
one for approved comments and one for unapproved comments. Each
display is paginated according to the numSearchResults preference.
The list of approved comments has, instead of a link to approve,
a link to unapprove.

The JavaScript table sorter has been removed since it doesn't make
sense to sort individual pages of a multi-page result set.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>