From 10e4f3b9a5baac83342b6a81a2081d89454bebc8 Mon Sep 17 00:00:00 2001 From: Colin Campbell Date: Wed, 19 Sep 2012 17:23:27 +0100 Subject: [PATCH] Bug 6679 Avoid critic failure caused by ambiguous code If countitems not set to 1 it was not being declared but is referred to outside this scope, generating runtime warnings and test failure Signed-off-by: Paul Poulain --- cataloguing/value_builder/marc21_linking_section.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cataloguing/value_builder/marc21_linking_section.pl b/cataloguing/value_builder/marc21_linking_section.pl index 275d3a5899..f317f8b2fb 100644 --- a/cataloguing/value_builder/marc21_linking_section.pl +++ b/cataloguing/value_builder/marc21_linking_section.pl @@ -226,7 +226,7 @@ sub plugin { my $record = MARC::Record::new_from_usmarc( $results->[$i] ); my $rechash = TransformMarcToKoha( $dbh, $record ); my $pos; - my $countitems = 1 if ( $rechash->{itemnumber} ); + my $countitems = $rechash->{itembumber} ? 1 : 0; while ( index( $rechash->{itemnumber}, '|', $pos ) > 0 ) { $countitems += 1; $pos = index( $rechash->{itemnumber}, '|', $pos ) + 1; @@ -406,4 +406,4 @@ sub plugin { output_html_with_http_headers $query, $cookie, $template->output; } -1; \ No newline at end of file +1; -- 2.39.5