From 1eb9e0393b5429116510710375834bf715d424c3 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 8 Oct 2021 14:42:48 +0000 Subject: [PATCH] Bug 29134: (follow-up) Specify which borrowernumber When performing a search that includes permissions we need to specify we are comparing the borrowers tabnle borrowernumber To test: 1 - Browse to Admin->Funds 2 - Edit a fund 3 - Click '+ Add users' 4 - Attempt a search, no results 5 - Check plack-error.log C4::Utils::DataTables::Members::search(): DBI Exception: DBD::mysql::st execute failed: Column 'borrowernumber' in IN/ALL/ANY subquery is ambiguous at /kohadevbox/koha/svc/members/search line 80 6 - Apply patch 7 - Repeat 1-3 8 - search for 'a' 9 - Result! Signed-off-by: Jonathan Druart Signed-off-by: Fridolin Somers (cherry picked from commit 591ffce832f061f46d2ef642898f5891c0fe7827) Signed-off-by: Victor Grousset/tuxayo --- C4/Utils/DataTables/Members.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm index 03ef3a0d03..05157db5e7 100644 --- a/C4/Utils/DataTables/Members.pm +++ b/C4/Utils/DataTables/Members.pm @@ -160,7 +160,7 @@ sub search { if ( $searchfieldstype eq 'standard' and C4::Context->preference('ExtendedPatronAttributes') and $searchmember ) { - push @where_strs_or, " borrowernumber IN ( SELECT DISTINCT borrowernumber FROM borrower_attributes JOIN borrower_attribute_types USING (code) WHERE staff_searchable = 1 AND attribute LIKE ? ) "; + push @where_strs_or, " borrowers.borrowernumber IN ( SELECT DISTINCT borrowernumber FROM borrower_attributes JOIN borrower_attribute_types USING (code) WHERE staff_searchable = 1 AND attribute LIKE ? ) "; push @where_args, $term; } -- 2.39.5