From 3b402d04e1a321afac02da84bae12f0342b776ad Mon Sep 17 00:00:00 2001 From: Fridolyn SOMERS Date: Fri, 22 Nov 2013 11:00:21 +0100 Subject: [PATCH] Bug 9578: avoid a search crash when attempting to sort results of invalid query MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit When searching with a sort (means not by relevance) and there is an error in Zebra connexion (server is down or query is wrong), you get the message : Error : Can't call method "sort" on an undefined value at /home/kohaadmin/src/C4/Search.pm line 405. This patch corrects by not performing sort if there are no no results. Steps to reproduce the error without patch: In OPAC go to Advanced Search Choose "Title" in first "Search for:" end enter "ccl=( and )" Display "More options" Set "Sort by" to "Title (A-Z)" Click "Search" at bootom of page Result: Error: Can't call method "sort" on an undefined value at /usr/share/kohaclone/C4/Search.pm line 430. After applying the patch, try that search again. This time, it should report not results found with out the error message. Alternative Test plan : - Set OPACdefaultSortField on something else than relevance - Perform a simple search with a wrong CCL query. For example : ccl=( and ) => You get the messge : No results found ... Patch behaves as expected. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer Adds another check to prevent a bad Zebra error message. Works as described, passes all tests and QA script. Signed-off-by: Galen Charlton --- C4/Search.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Search.pm b/C4/Search.pm index 34d0fd7117..3ca722c843 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -426,7 +426,7 @@ sub getRecords { warn "Ignoring unrecognized sort '$sort' requested" if $sort_by; } } - if ($sort_by && !$scan) { + if ( $sort_by && !$scan && $results[$i] ) { if ( $results[$i]->sort( "yaz", $sort_by ) < 0 ) { warn "WARNING sort $sort_by failed"; } -- 2.39.5