From 79b8a27c0cb9702743cea8dc4244cfa9a060a3d2 Mon Sep 17 00:00:00 2001 From: Garry Collum Date: Mon, 15 Feb 2010 10:43:23 -0500 Subject: [PATCH] Bug 3449: Fixes the perpetual error message that pops up when filtering by tag reviewer. Duplicates the code for searching by reviewer in the form that is used in searching via a link. It looks like it was the intention of the original writer to filter by borrower number or by name. Filtering by name was not implemented. Added a FIXME reference to indicate this. Signed-off-by: Galen Charlton --- tags/review.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tags/review.pl b/tags/review.pl index 0667f3d482..d4db97284c 100755 --- a/tags/review.pl +++ b/tags/review.pl @@ -178,11 +178,12 @@ if ($filter = $input->param('to')) { } } if ($filter = $input->param('approver')) { # name (or borrowernumber) from input box - if (($filter =~ /^\d+$/ and $filter > 0) or - (1) ){ # $filter=get borrowernumber from name + if ($filter =~ /^\d+$/ and $filter > 0) { + # $filter=get borrowernumber from name + # FIXME: get borrowernumber from name not implemented. $template->param(filter_approver=>$filter); $filters{approved_by} = $filter; - # } else { + } else { push @errors, {approver=>$filter}; } } -- 2.39.5