From 1e52cd7cf251d5399c49aae39355e87d44575fe3 Mon Sep 17 00:00:00 2001 From: Baptiste Wojtkowski Date: Tue, 9 Jul 2024 16:08:39 +0200 Subject: [PATCH] Bug 37285: Printing lists only prints the ten first results GIVEN koha in a version later than 22.11, a list with more than ten entries WHEN the user tries to print the list THEN only the ten first results are printed EXPECTED THEN all results are printed It looks like it is an undesired effect of BZ36858. Page remains set even while printing, therefore, however the number of rows is not set, default value (10) is used. TEST PLAN 1 - create a list with more than 10 items 2 - print the list -> there is a pagination and that only 10 items are printed Apply patch 3 - print the list again -> every items are being printed Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize (cherry picked from commit 64027daadcea8c44cb73aae71a48ac64d527ed3f) Signed-off-by: Lucas Gass (cherry picked from commit 0f8f20a01fede0991500bff529d540959fea6251) Signed-off-by: Fridolin Somers --- virtualshelves/shelves.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/virtualshelves/shelves.pl b/virtualshelves/shelves.pl index 52cc6d6c9a..4fdc6f0c0b 100755 --- a/virtualshelves/shelves.pl +++ b/virtualshelves/shelves.pl @@ -273,7 +273,9 @@ if ( $op eq 'view' ) { my $direction = $query->param('direction') || 'asc'; $direction = 'asc' if $direction ne 'asc' and $direction ne 'desc'; my $rows; - unless ( $query->param('print') ) { + if ( $query->param('print') ) { + $page=""; + } else { $rows = C4::Context->preference('numSearchResults') || 20; } -- 2.39.5