From 95c3ed60c90ecc5be9a604d06d7a1d7ab39b9643 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Thu, 7 Jan 2021 13:44:33 +0100
Subject: [PATCH] Bug 19540: Tell the patron why a hold cannot be placed on
 items

This patch adds an explanation when a hold cannot be placed, in some situation:
tooManyReserves
tooManyHoldsForThisRecord
tooManyReservesToday
itemAlreadyOnHold

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 01985605434b7b78cb8f234f8ea66e0a16b3f8c5)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit e1caed6c63d9a831e332ccee32123a591ae2b7e1)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
---
 .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt     | 10 +++++++++-
 opac/opac-reserve.pl                                   |  2 +-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
index 930c2bf75b..79b68f7a36 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
@@ -202,8 +202,16 @@
                                     [% IF ( bibitemloo.already_reserved ) %]
                                         <div class="alert alert-warning">You have already requested this title.</div>
                                     [% ELSE %]
-                                        [% IF ( bibitemloo.already_patron_possession ) %]
+                                        [% IF bibitemloo.alreadypossession %]
                                             <div class="alert alert-warning">This title cannot be requested because it's already in your possession.</div>
+                                        [% ELSIF bibitemloo.tooManyReserves %]
+                                            <div class="alert alert-warning">This title cannot be requested because you reached the maximum number of holds.</div>
+                                        [% ELSIF bibitemloo.tooManyHoldsForThisRecord %]
+                                            <div class="alert alert-warning">This title cannot be requested because you exceeded max holds per record.</div>
+                                        [% ELSIF bibitemloo.tooManyReservesToday %]
+                                            <div class="alert alert-warning">This title cannot be requested because you reached the daily hold limit.</div>
+                                        [% ELSIF bibitemloo.itemAlreadyOnHold %]
+                                            <div class="alert alert-warning">This title cannot be requested because you already have hold for this item.</div>
                                         [% ELSE %]
                                             [% UNLESS ( bibitemloo.bib_available ) %]
                                                 <div class="alert">There are no items that can be placed on hold.</div>
diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
index d6ba57fc9d..48b661e5f3 100755
--- a/opac/opac-reserve.pl
+++ b/opac/opac-reserve.pl
@@ -634,7 +634,7 @@ foreach my $biblioNum (@biblionumbers) {
 
     my $status = CanBookBeReserved( $borrowernumber, $biblioNum )->{status};
     $biblioLoopIter{holdable} &&= $status eq 'OK';
-    $biblioLoopIter{already_patron_possession} = $status eq 'alreadypossession';
+    $biblioLoopIter{$status} = 1;
 
     if ( $biblioLoopIter{holdable} and C4::Context->preference('AllowHoldItemTypeSelection') ) {
         # build the allowed item types loop
-- 
2.39.5