From 64a9e3c99951b466ffbb0b9b3f5d5654b5e0f6fb Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 13 Nov 2023 16:46:17 +0000 Subject: [PATCH] Bug 35285: Unit tests This patch adds unit tests for the new 'is_html' function introduced in Koha::Notice::Message and update the tests to include the new plaintext handling of html_content. Signed-off-by: David Nind test Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer --- t/db_dependent/Koha/Notice/Message.t | 103 ++++++++++++++++++++++++++- 1 file changed, 101 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/Koha/Notice/Message.t b/t/db_dependent/Koha/Notice/Message.t index 72192655f9..94c383f3b7 100755 --- a/t/db_dependent/Koha/Notice/Message.t +++ b/t/db_dependent/Koha/Notice/Message.t @@ -19,7 +19,7 @@ use Modern::Perl; -use Test::More tests => 1; +use Test::More tests => 2; use C4::Letters qw( GetPreparedLetter EnqueueLetter ); @@ -29,11 +29,83 @@ use t::lib::TestBuilder; my $schema = Koha::Database->new->schema; my $builder = t::lib::TestBuilder->new; -subtest 'html_content() tests' => sub { +subtest 'is_html() tests' => sub { plan tests => 2; $schema->storage->txn_begin; + my $template = $builder->build_object( + { + class => 'Koha::Notice::Templates', + value => { + module => 'test', + code => 'TEST', + message_transport_type => 'email', + is_html => '0', + name => 'test notice template', + title => '[% borrower.firstname %]', + content => 'This is a test template using borrower [% borrower.id %]', + branchcode => "", + lang => 'default', + } + } + ); + + my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); + my $firstname = $patron->firstname; + my $borrowernumber = $patron->id; + + my $prepared_letter = GetPreparedLetter( + ( + module => 'test', + letter_code => 'TEST', + tables => { + borrowers => $patron->id, + }, + ) + ); + + my $message_id = EnqueueLetter( + { + letter => $prepared_letter, + borrowernumber => $patron->id, + message_transport_type => 'email' + } + ); + my $message = Koha::Notice::Messages->find($message_id); + + ok( !$message->is_html, "Non html template yields a non html message" ); + + $template->is_html(1)->store; + $prepared_letter = GetPreparedLetter( + ( + module => 'test', + letter_code => 'TEST', + tables => { + borrowers => $patron->id, + }, + ) + ); + + $message_id = EnqueueLetter( + { + letter => $prepared_letter, + borrowernumber => $patron->id, + message_transport_type => 'email' + } + ); + + $message = Koha::Notice::Messages->find($message_id); + ok( $message->is_html, "HTML template yields a html message" ); + + $schema->storage->txn_rollback; +}; + +subtest 'html_content() tests' => sub { + plan tests => 3; + + $schema->storage->txn_begin; + my $template = $builder->build_object( { class => 'Koha::Notice::Templates', @@ -116,6 +188,33 @@ WRAPPED "html_content returned the correct html wrapped letter including stylesheet" ); + $template->is_html(0)->store; + $prepared_letter = GetPreparedLetter( + ( + module => 'test', + letter_code => 'TEST', + tables => { + borrowers => $patron->id, + }, + ) + ); + + $message_id = EnqueueLetter( + { + letter => $prepared_letter, + borrowernumber => $patron->id, + message_transport_type => 'email' + } + ); + + $wrapped_compare = "
This is a test template using borrower $borrowernumber
"; + + $message = Koha::Notice::Messages->find($message_id); + is( + $message->html_content, $wrapped_compare, + "html_content returned the correct html wrapped letter for a plaintext template" + ); + $schema->storage->txn_rollback; }; -- 2.39.5