]> git.koha-community.org Git - koha.git/log
koha.git
13 years agoBug 4189 : Searching z39.50 without selecting any servers results in error message
Tomas Cohen Arazi [Wed, 30 Mar 2011 20:08:57 +0000 (17:08 -0300)]
Bug 4189 : Searching z39.50 without selecting any servers results in error message

This patch makes z3950_search.pl handle the situation properly, and z3950_search.tmpl
show a proper message instead of a program error. All this, in case the javascript
checks that alert the user (that at least one target has to be chosen)  are by-passed.

Regards
To+

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed small translation problem in javascript alert message.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4747f5adb25dce337fe295e3442e19bcacadeffa)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6088: remove Perl warning
Paul Poulain [Thu, 7 Apr 2011 11:09:27 +0000 (11:09 +0000)]
Bug 6088: remove Perl warning

caused by use warnings;

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 65c21fa52f9a44920e341f39b23bd877f5c87c84)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6072: fixing permission inconsistencies MT5306
Paul Poulain [Wed, 6 Apr 2011 08:54:38 +0000 (10:54 +0200)]
Bug 6072: fixing permission inconsistencies MT5306

In large libraries, some librarian may have permission only
to recieve shipments This patch fixes some permission :
* booksellers page = accessible to anyone that has at least 1 acq permission
* parcels = accessible to anyone with order_recieve
* supplier detail = accessible to anyone that has at least 1 acq permission,
  but modifying accessible only if vendor_manage

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c0ecd7df4fdfa9e2520b1acc498a820f6abebaf1)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 6109, Hey!
Owen Leonard [Thu, 7 Apr 2011 13:44:28 +0000 (15:44 +0200)]
Fix for Bug 6109, Hey!

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bd4bf5485c88314e3d0e9794f520e88dced6d790)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4912: Follow-up fix for Bug 4912, redirect user to correct lists
Owen Leonard [Thu, 7 Apr 2011 08:04:23 +0000 (10:04 +0200)]
Bug 4912: Follow-up fix for Bug 4912, redirect user to correct lists

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d269389839415ce4d14f7bc01635978807374631)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug #6112 - Missing fields in overdues csv file
Alex Arnaud [Thu, 7 Apr 2011 14:30:13 +0000 (16:30 +0200)]
Bug #6112 - Missing fields in overdues csv file

Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 913d520be7fddb8664753fa202f4f0362634c833)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug #6107 - Problems when duplicate a patron on memberentry.pl
Alex Arnaud [Thu, 7 Apr 2011 10:05:27 +0000 (12:05 +0200)]
Bug #6107 - Problems when duplicate a patron on memberentry.pl

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 52ff3ca6ec6dbb801f27f6de84747032828ad004)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6099: error in report pagination when GROUP BY
Jonathan Druart [Thu, 7 Apr 2011 14:14:29 +0000 (16:14 +0200)]
Bug 6099: error in report pagination when GROUP BY

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: fdurand <frederic.durand@univ-lyon2.fr>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 6de105084e8ed08846545848e0d5cd3e3ba9d178)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5903 : French authorised values fixed
Paul Poulain [Thu, 7 Apr 2011 09:53:37 +0000 (11:53 +0200)]
Bug 5903 : French authorised values fixed

country codes must be in capital letters

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b67375b3d24f40026b1f21cacb1dab1a2150d341)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5275: enable switching back to default biblio framework
Paul Poulain [Thu, 7 Apr 2011 14:15:54 +0000 (16:15 +0200)]
Bug 5275: enable switching back to default biblio framework

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f0de62e4cc26b21f18005e25d32431c70ef78b61)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 6037, Invalid markup, missing breadcrumbs on Keyword to MARC Mapping...
Stéphane Delaune [Thu, 7 Apr 2011 13:35:13 +0000 (15:35 +0200)]
Fix for Bug 6037, Invalid markup, missing breadcrumbs on Keyword to MARC Mapping page

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a59b1d23bb807b3946320365127b82fbcc144914)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3072: Search for Heading-Main in authorities
Marcel de Rooy [Thu, 7 Apr 2011 09:42:30 +0000 (11:42 +0200)]
Bug 3072: Search for Heading-Main in authorities

Includes Heading-Main in authorities bib1 attribute set.
Also includes Any in authorities bib1 (was still missing).
Also removes temporary fix in AuthoritiesMarc.pm.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Rebased after pushed fix for #5924.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 6e58529bdd78f0593c9ad8b767715ff2d32e8ba8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6096 Correctly return arrayref from GetAllShelves
Colin Campbell [Thu, 7 Apr 2011 15:30:17 +0000 (17:30 +0200)]
Bug 6096 Correctly return arrayref from GetAllShelves

Follow on from bug 5529 GetAllShelves was also vaguely stuffing
an arrayref into an array
Some signs of cut and paste (unnecessary @params variable)
Calling code now does not have to shuffle the return about
to get the reference. Also removed a debug warn

Signed-off-by: fdurand <frederic.durand@univ-lyon2.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c0655aabe47cfe21e7846b7a8956db92c1e5b5d2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5529 Absence or Presence of lists not being reliably returned
Colin Campbell [Thu, 7 Apr 2011 14:25:27 +0000 (16:25 +0200)]
Bug 5529 Absence or Presence of lists not being reliably returned

C4::VirtualShelves::GetRecentShelves contained some rather confused
code The contents of the requested list are returned in an arrayref
which was in its turn being wrapped needlessly in an array
As a result the returned array always consisted of a single element
irrespective of the number of lists.
Made the routine return the arrayref, which can now be tested directly
Unfortunately rather than fixing this we had previously coded around it
assuming it to be a "design" decision. Have amended other calls of
the subroutine resulting in some hopefully less obscure code

Fixed logic error in the results template which displayed new list
within a test for the presence of lists

Removed the offset parameter from the sql in the routine as it was hardcoded
to 0 i.e. the default value

Signed-off-by: fdurand <frederic.durand@univ-lyon2.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0cf2eccfe926f77753a2b948e2babf077e2975d3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug #6082 - On aqbudgets.pl bug on the Statistic's combobox
Alex Arnaud [Thu, 7 Apr 2011 09:59:22 +0000 (11:59 +0200)]
Bug #6082 - On aqbudgets.pl bug on the Statistic's combobox

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 22dc04e24c9af810672ee8f6e313316f3bcc9a59)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6106: add item not respecting framework in acq The PrepareItemrecordDisplay sub...
Paul Poulain [Thu, 7 Apr 2011 15:15:53 +0000 (17:15 +0200)]
Bug 6106: add item not respecting framework in acq The PrepareItemrecordDisplay sub builds an item framework for later use in ACQ Some cases were missing : item subfield connected to a plugin, hidden subfield, long size subfield.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e5ff05857e5b99ab19210bc272086f253ea9404b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug #6110 - fix Callnumber index mistake
Alex Arnaud [Thu, 7 Apr 2011 12:59:53 +0000 (14:59 +0200)]
Bug #6110 - fix Callnumber index mistake

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2950fc5596542ff181f05f766f32855089f96528)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoNew developer to the history
Chris Cormack [Thu, 7 Apr 2011 20:43:06 +0000 (08:43 +1200)]
New developer to the history
(cherry picked from commit 2a489184c088f0b023285069706f8ff614e4704e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 4903: enable OAI-DC output when install done in standard mode
Galen Charlton [Thu, 7 Apr 2011 07:57:45 +0000 (09:57 +0200)]
bug 4903: enable OAI-DC output when install done in standard mode

Based on patch by Tomás Cohen Arazi <tomascohen@gmail.com>,
revised to work regardless of the installation mode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 46041a8fdc51c9c1173cd8cc343e6ac1f7bd46f6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.07.003
Chris Nighswonger [Sat, 16 Apr 2011 17:47:05 +0000 (13:47 -0400)]
Updating Version Number to 3.02.07.003

13 years agoBug #6064 Improvement of default value usage in overdue
Sophie Meynieux [Thu, 7 Apr 2011 08:21:16 +0000 (10:21 +0200)]
Bug #6064 Improvement of default value usage in overdue

Change default value in overduerules table for delayn (NULL instead of 0) and fix GetBranchcodesWithOverdueRules function

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 141a52ac30c94b0f5e8dde0d29552bc8d5f44553)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6062: ordering basketgroups
Paul Poulain [Tue, 5 Apr 2011 12:43:23 +0000 (14:43 +0200)]
Bug 6062: ordering basketgroups

When you have many basketgroups, you get the oldest one on top. Usually, you
have something to do on recent ones, so it's better to have basket groups
ordered DESC

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 311e81810ab894b2b7f2dc186cbf3a8c6a337a1f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5951 : consistency change: s/planning/statistic/
Paul POULAIN [Tue, 5 Apr 2011 14:26:16 +0000 (16:26 +0200)]
Bug 5951 : consistency change: s/planning/statistic/

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit aaa6ecf2b6bad86b51ec21299407c92840d2417c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFixing typo in kohaversion.pl
Chris Nighswonger [Sat, 16 Apr 2011 17:32:39 +0000 (13:32 -0400)]
Fixing typo in kohaversion.pl

13 years agoBug 5915 : C4::AuthoritiesMarc AddAuthority
Paul Poulain [Tue, 5 Apr 2011 09:04:42 +0000 (11:04 +0200)]
Bug 5915 : C4::AuthoritiesMarc AddAuthority

Fixing 100$a simple error: Sometimes, language is encoded fre50 and not
frey50.
This patch adds check for that problem

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c9def9328613401f751f038653273b35b3e9d84e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.07.002
Chris Nighswonger [Sat, 16 Apr 2011 17:23:52 +0000 (13:23 -0400)]
Updating Version Number to 3.02.07.002

13 years ago5936: Remove some obsolete db columns from aqbooksellers and aqbudgets if needed
Marcel de Rooy [Wed, 6 Apr 2011 11:35:37 +0000 (11:35 +0000)]
5936: Remove some obsolete db columns from aqbooksellers and aqbudgets if needed

Removes obsolete columns from aqbooksellers and aqbudgets if needed.
aqbooksellers: deliverydays followupdays followupscancel invoicedisc nocalc
specialty
aqbudgets: budget_description

These columns should not exist in a fresh install from kohastructure.sql, but
originate from older 3.0 versions.
One line in acqui/updatesupplier.pl referring to one of these columns is
removed too.

This patch therefore does not change functionality, but only keeps your db in
shape.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Rebased April 6.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5923 : Authorities list :removing link on Summary
Henri-Damien LAURENT [Tue, 5 Apr 2011 08:40:14 +0000 (10:40 +0200)]
Bug 5923 : Authorities list :removing link on Summary

removing the link to authority details on authority List directly from summary
And adding a generic link to details

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 21404359d498865ea55beb745327763a819f81fe)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoRemoving conflict markers
Chris Cormack [Thu, 7 Apr 2011 03:55:33 +0000 (15:55 +1200)]
Removing conflict markers
(cherry picked from commit c649ed9257d3c7f4d71f484d8ea6e2d5af2e48d7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years ago(Bug 4049) Searching itemtypes returning noise
Henri-Damien LAURENT [Tue, 5 Apr 2011 12:13:51 +0000 (14:13 +0200)]
(Bug 4049) Searching itemtypes returning noise

Fix the problem of searching on partial itemtypes strings
for instance, itemtype="ARTICLE DE PERIODIQUE", itemtype="PERIODIQUE"
searching on itemtype="PERIODIQUE" would also get "ARTICLE DE PERIODIQUE"

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 700de9664d0e9016845d12916905e458cab9dbd4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5213 - Suffix number sequence not resetting properly in hmyymmincr barcode autoge...
Chris Nighswonger [Tue, 5 Apr 2011 09:50:48 +0000 (11:50 +0200)]
Bug 5213 - Suffix number sequence not resetting properly in hmyymmincr barcode autogen pattern

Two things are happening.

First, the SELECT does not account for a branchcode greater than 2 chars.

This is fixed by just selecting the final four digits representing the
incremental suffix from the barcode field.

Second, the incremental suffix (4 digits) is not rolling back over to zero when
reaching 9999.

This pattern probably needs help. It should allow for cataloging of 10000 items
per month as is. I would not recommend doing barcode numbering this way, but
need to support it since it is in use in at least one library.

This patch also impliments strict and warnings per Bug 2505

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 8ca5d5ff85c429ee972b3f80f91f5b27a58cf5d5)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6077: qty not incremented for AcqCreateItem=recieve
Paul Poulain [Wed, 6 Apr 2011 08:02:31 +0000 (10:02 +0200)]
Bug 6077: qty not incremented for AcqCreateItem=recieve

When you want to create items on order recieve, the qty was not incremented
when the librarian adds an item with the +

This was because the js was expecting the qty field to be id=quantity

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d58092dd96383378f8abdce92d07c1795c617f97)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5156, JavaScript error when adding list
Owen Leonard [Wed, 6 Apr 2011 09:27:11 +0000 (11:27 +0200)]
Fix for Bug 5156, JavaScript error when adding list

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9bb36148fddd4cb249c83033c5d6c27bef0513a6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6028 : MT3815: Quickfix for CSV export (9999 rows limitation)
Matthias Meusburger [Wed, 6 Apr 2011 14:39:36 +0000 (16:39 +0200)]
Bug 6028 : MT3815: Quickfix for CSV export (9999 rows limitation)

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 3a8be8d8e0619e248ee02a851a0f21497d3490a7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoThis patch fixes the broken pagination in members-search.pl
Koustubha Kale [Sat, 2 Apr 2011 16:53:06 +0000 (22:23 +0530)]
This patch fixes the broken pagination in members-search.pl

Small patch to fix Error 404 which comes up when we click on pagination links after searching in Patron Card creator.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 332e701c258a126cbc90862c12249de7aaada710)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6100: request.pl should check maxreserves exists
Jared Camins-Esakov [Wed, 6 Apr 2011 18:00:47 +0000 (14:00 -0400)]
Bug 6100: request.pl should check maxreserves exists

Adds a check to confirm that the maxreserves syspref actually has a value before
using it. Also fixes an off-by-one error in the maxreserves calculation that
would allow librarians to place maxreserves + 1 holds for patrons.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 8b582d863debf1a60c69560b1cb797a9931bdcf8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6032: Increase zebra biblio register stores
Robin Sheat [Wed, 6 Apr 2011 23:18:32 +0000 (11:18 +1200)]
Bug 6032: Increase zebra biblio register stores

This keeps the package versions of the zebra configuration in sync with
the makefile-installed ones.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0645f83c225c6b95e3b0c7b091b493481a35d3f2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6032: Give biblio register and shadow sane default max sizes
Jared Camins-Esakov [Wed, 6 Apr 2011 18:28:49 +0000 (14:28 -0400)]
Bug 6032: Give biblio register and shadow sane default max sizes

The out-of-the-box maximum size for the biblio register and shadow stores is
4GB, which is much too small for even medium sized libraries. This makes the
default maximum 20GB, which should be enough for even most large libraries.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2b71959a88029d9b948e13ad2f1f863fad8c44d6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4374 Improve biblio data entry form regarding hidden/mandatory fields
Frédéric Demians [Wed, 6 Apr 2011 08:14:29 +0000 (10:14 +0200)]
Bug 4374 Improve biblio data entry form regarding hidden/mandatory fields

Biblio framework has 3 entry points controlling if input box are
displayed by default in data entry form:

  - 'mandatory' flag at field level
  - 'mandatory' flag at subfield level
  - 'hidden' flag at subfield level

It doesn't work as it should (?):

  - All subfields are expanded (shown) if their field is mandatory
  - A subfield containing anything is always expanded whatever it contains
  - A mandatory subfield is always expanded
  - An hidden subfield isn't expanded.

Default framework having 0 in all marc_subfield_structure.hidden, by default
all subfields will be expanded.

TO BE INTEGRATED IN RELEASE NOTES:

  Koha sysadmin should have to edit its frameworks to add hidden=1 in
  appropriate subfields.

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit cecdc193696c6c91560128da5954681aa7ce610f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6014 : Removing a leftover warn
Chris Cormack [Thu, 7 Apr 2011 01:16:26 +0000 (13:16 +1200)]
Bug 6014 : Removing a leftover warn
(cherry picked from commit 13ad14a7540dab8b27a21fb6cb00a6edc875040d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6014 : MT3138 Adding some permission management to viewlog
Henri-Damien LAURENT [Wed, 6 Apr 2011 15:28:45 +0000 (17:28 +0200)]
Bug 6014 : MT3138 Adding some permission management to viewlog

If user can not access reports, then form to search the logs is not displayed.
It also improves the presentation.

C4/Log.pm
- adds the fact that we can enter multiple actions
- fixes the fact that user information was truncated

circ-menu.inc:
Fixing information passed to the viewlog from circ-menu

Signed-off-by: fdurand <frederic.durand@univ-lyon2.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 99b49e2b1aa2e5d2629f1167e2b63c3b3158ffe8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 4837 make circ print page show item type description
Nicole Engard [Tue, 5 Apr 2011 13:30:07 +0000 (15:30 +0200)]
bug 4837 make circ print page show item type description

Signed-off-by: Guillaume Hatt <guillaume.hatt@€nc.sorbonne.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fcbcdcf4cebdb32544a545d8ef91de1bbe67f457)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4196 -Followup : Defintion of popularity index into Unimarc setup
fdurand [Tue, 5 Apr 2011 15:07:31 +0000 (17:07 +0200)]
Bug 4196 -Followup : Defintion of popularity index into Unimarc setup

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ecbeafff07fa32918d552bbf4ba9cd8410207633)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5941 : (MT4425) Replace search 'an' by 'an, phr' in searchresultlist.tmpl
Alex Arnaud [Tue, 5 Apr 2011 07:54:11 +0000 (09:54 +0200)]
Bug 5941 : (MT4425) Replace search 'an' by 'an, phr' in searchresultlist.tmpl

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 99f49c1108dad5ef7548929b23d4a3815ae1a166)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBZ6065: confirmation when deleting an order
Paul Poulain [Tue, 5 Apr 2011 12:54:48 +0000 (14:54 +0200)]
BZ6065: confirmation when deleting an order

when clicking on "delete order", there is no confirmation box, the order line is
deleted without any question !

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2a28b30a3c5a02475d59d4beab9c3b67cfc666e3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5942, sql for UNIMARC Authorities
Stéphane Delaune [Mon, 4 Apr 2011 13:22:37 +0000 (15:22 +0200)]
Bug 5942, sql for UNIMARC Authorities

(MT #4339) init default UNIMARC sql structure

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 132743f66bc07f6b8799835aac6cf440430bd44e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6056: Notes were not shown when modifying order line
Katrin Fischer [Tue, 5 Apr 2011 11:42:57 +0000 (13:42 +0200)]
Bug 6056: Notes were not shown when modifying order line

To test:
- add a new order in acquisitions with some content in the notes field
- save order
- modify order - Notes field will be shown as empty

The template variable for notes is missing from the template.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9cab9be3d6114898e0b8354d784fb8d56ad51fbc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5949 : Popup alert when deleting items from basket, also change planning value...
Christophe Croullebois [Mon, 4 Apr 2011 10:29:36 +0000 (12:29 +0200)]
Bug 5949 : Popup alert when deleting items from basket, also change planning value to statistics

(MT #2391) : acqui/neworderempty.pl

Multiple fixes in neworderempty.pl, mainly about Modify order line page, link to edit catalog, user can delete items with popup information and can't add items also with popup explanation.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- changed the the link from 'Edit Catalog' to 'Edit record' (like on result list)
- changed position of 'Edit record' to be shown behind the label 'Catalog details' instead of showing behind the Title.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1f323c00a14673ae83ae24b2502aa172d7949781)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5947 Suggestions : add date to the search query
Alex Arnaud [Mon, 4 Apr 2011 15:17:35 +0000 (17:17 +0200)]
Bug 5947 Suggestions : add date to the search query

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixes searching by dates, like 'Suggested on:'
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 3603ae6274da149370fd38ce642848738b11fcdc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3628: opacSerialDefaultTab
Marcel de Rooy [Mon, 4 Apr 2011 10:04:30 +0000 (12:04 +0200)]
Bug 3628: opacSerialDefaultTab

This partial fix makes this existing pref visible in the interface.
It should work for UNIMARC. Some work still needs to be done at the MARC side.

Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0dba0e0d3c687ffa0c8ba64ddf5c5f217c68aa0a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.07.001
Chris Nighswonger [Sat, 16 Apr 2011 15:52:21 +0000 (11:52 -0400)]
Updating Version Number to 3.02.07.001

13 years agoBug 5860: Adding duplicate stocknumber fails silently
Katrin Fischer [Mon, 4 Apr 2011 11:20:20 +0000 (11:20 +0000)]
Bug 5860: Adding duplicate stocknumber fails silently

When adding a duplicate stocknumber the duplicate was not saved to the database.
This happened, because the field stocknumber in table items was declared to be unique.
Discussion on bug suggests to lift this restriction.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested. Corrected typo in updatedatabase script. Version 3.01.00.095 introduced the index with double s, although structure had only one s in index name.
Unaware of this bug, I entered the more general bug 6041 for similar problems with modifying items.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a8ffb2273b63c398492a7cbd08394adedb2aeadb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoAdding a javascript function to check the validation of a record with a budget.
koha-preprod [Mon, 7 Feb 2011 16:12:49 +0000 (11:12 -0500)]
Adding a javascript function to check the validation of a record with a budget.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9dc69cf47fb374b64dcc2ee3716cffa3b15cfb7c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5948 : Creation of a quantity column in receipt summary
Christophe Croullebois [Mon, 4 Apr 2011 09:21:18 +0000 (11:21 +0200)]
Bug 5948 : Creation of a quantity column in receipt summary

In receipt summary the quantity did'nt appear in already received table, this patch fixes the omission

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch tested on current master. Works like advertised.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b9d434c18f3ff5a4d168cf24454d51ede1523fde)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoSmall patch to make myself feel important
Robin Sheat [Tue, 29 Mar 2011 04:01:38 +0000 (17:01 +1300)]
Small patch to make myself feel important

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit dc37fe9730f00d8dcc1c97029da816f66a0f9a02)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoEscape the double quotes in authority search queries to prevent errors.
Frédérick Capovilla [Fri, 1 Apr 2011 07:16:51 +0000 (09:16 +0200)]
Escape the double quotes in authority search queries to prevent errors.

Before this fix, any search with double-quotes would return an error
500.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 21993ab00a853d2cf7afb314bd2b6bacb0439ecc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5990: Lists and Cart show LOC code not Location Authorized value
Ian Walls [Wed, 30 Mar 2011 17:39:53 +0000 (13:39 -0400)]
Bug 5990: Lists and Cart show LOC code not Location Authorized value

Lists in the OPAC, and Cart on both sides, show the LOC code for items, rather
than the appropriate Description from Authorised Values.  This is because the
code uses GetItemInfo, which is a very heavy-weight call to only retrieve some
of the desired information.

This patch introduces a new subroutine in C4::Items, GetItemsLocationInfo, which
returns the branch names for both home- and holdingbranches, the location code,
both opac and intranet location descriptions, itemcallnumber and cn_sort. This
should be used instead of GetItemsInfo in any case where the locational
information is all that's required, as it's much more streamlined and efficient.

In the OPAC Lists, this only applies if OPACXSLTResultsDisplay is 'off' (set to
'normal').

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 90392c19cc343ada611c1f06e4b5c20f3dd6dc93)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6005: Fixes Transit slips cause FF4 to display "prevent this page from opening...
root [Wed, 30 Mar 2011 14:44:59 +0000 (10:44 -0400)]
Bug 6005: Fixes Transit slips cause FF4 to display "prevent this page from opening additional dialogs"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5d707b5e9b7f18351d9b996f5f73a1ae53066080)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 3523 - Menu of existing lists limited to 10
Owen Leonard [Wed, 30 Mar 2011 13:34:25 +0000 (15:34 +0200)]
Fix for Bug 3523 - Menu of existing lists limited to 10

- adding "more" option to the search results dropdown
- offering a scrolling list on the add-to-list popup
- lists add popup shows the full list of all
  the patron's lists, divided into groups of private and
  public lists.

Can be improved by a fix for Bug 5529

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 731b933d51367489422b90fa7021cfc42c747584)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoMT3289 : check_sysprefs.pl case sensitive variable names
Henri-Damien LAURENT [Sun, 11 Apr 2010 18:40:57 +0000 (20:40 +0200)]
MT3289 : check_sysprefs.pl case sensitive variable names

Variable names for systempreferences are now case sensitive.
Changing check_sysprefs in relation with this change

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 641616ef7fd43600864d46f39b938ef3cd8cd4f3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3644 Add support for NORMARC
Magnus Enger [Fri, 5 Mar 2010 10:58:14 +0000 (11:58 +0100)]
Bug 3644 Add support for NORMARC

- XSLT for the OPAC
- Value_builders for lesder, 007 and 008
- Default NORMARC framework
- Reverse MARC logic of some subs, so MARC21 is default (and works for NORMARC)
- Add NORMARC as an option to the syspref marcflavour
- Add record.abs for NORMARC
- Add NORMARC and nb as options to Makefile.PL
- Add etc/zebradb/lang_defs/nb/sort-string-utf.chr
- Copy MARC21slim2OAIDC.xsl to NORMARCslim2OAIDC.xsl

Some things are still missing, e.g.:

- XSLT for Intranet
- More MARC21slim2*.xsl transformations
(cherry picked from commit edf8ad5d5da9c11e0dc61c1df40ce977e9e6a125)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoAnother wrong encoding in installer/data/mysql/nb-NO/2-Valgfritt/
Magnus Enger [Tue, 29 Mar 2011 19:15:08 +0000 (21:15 +0200)]
Another wrong encoding in installer/data/mysql/nb-NO/2-Valgfritt/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit 759499d6e829fad122c7a98668603598e9cea768)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix wrong encodings in installer/data/mysql/nb-NO/2-Valgfritt/
Magnus Enger [Tue, 29 Mar 2011 19:13:41 +0000 (21:13 +0200)]
Fix wrong encodings in installer/data/mysql/nb-NO/2-Valgfritt/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit d5608708c179b5377794129f76fb0e6e6115448f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoA couple of missing translations in installer/data/mysql/nb-NO/2-Valgfritt/
Magnus Enger [Tue, 29 Mar 2011 19:11:28 +0000 (21:11 +0200)]
A couple of missing translations in installer/data/mysql/nb-NO/2-Valgfritt/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit a299f54a9f4dce47530f90176a96bc6abaeb0cd8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix typo in installer/data/mysql/nb-NO/2-Valgfritt/sample_patrons.txt
Magnus Enger [Tue, 29 Mar 2011 19:06:47 +0000 (21:06 +0200)]
Fix typo in installer/data/mysql/nb-NO/2-Valgfritt/sample_patrons.txt

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit 93d968cb30d26dbc3aa2933eb49f74f25611b2d4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoAdd files to installer/data/mysql/nb-NO/2-Valgfritt/
Magnus Enger [Tue, 29 Mar 2011 14:26:47 +0000 (16:26 +0200)]
Add files to installer/data/mysql/nb-NO/2-Valgfritt/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit 4a5f1ec49a081319fdc1f00311900119df90eeae)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoTranslate OPACSearchForTitleIn in installer/data/mysql/nb-NO/1-Obligatorisk/sysprefs.sql
Magnus Enger [Tue, 29 Mar 2011 11:32:25 +0000 (13:32 +0200)]
Translate OPACSearchForTitleIn in installer/data/mysql/nb-NO/1-Obligatorisk/sysprefs.sql

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit 1564cd0d004aef5b0494fd4eb9a4b4ebc78fa082)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoAdd files in installer/data/mysql/nb-NO/1-Obligatorisk/
Magnus Enger [Tue, 29 Mar 2011 10:31:42 +0000 (12:31 +0200)]
Add files in installer/data/mysql/nb-NO/1-Obligatorisk/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit e69c01faf6da651fb9ea0eded69a6679e71876df)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoAdd a copy of MARC21 data
Magnus Enger [Mon, 28 Mar 2011 21:00:56 +0000 (23:00 +0200)]
Add a copy of MARC21 data

Copy installer/data/mysql/en/marcflavour/marc21
to   installer/data/mysql/nb-no/marcflavour/marc21

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit 7af27271272d11872ced646f2a1f72616095b56d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoAdd sample Z39.50 servers
Magnus Enger [Tue, 9 Mar 2010 11:38:23 +0000 (12:38 +0100)]
Add sample Z39.50 servers

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit f086d7e1bf402c4a9fe341421a566abb444fe7f8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5708 : Get Correct Discount when levying rentalcharge
Colin Campbell [Tue, 29 Mar 2011 13:57:41 +0000 (09:57 -0400)]
Bug 5708 : Get Correct Discount when levying rentalcharge

Branch can be a parameter so it should be included in the rule retrieval
Need to select the most appropriate rule from those returned
(was defaulting to first returned!)
Try to make what's happening a bit less opaque
null fields are returned as undefined not 'NULL' by DBI

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 88cb47339a8eab4ff4b95956207bf2d1dcdffeff)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5982 : OPAC Serials Minor change in description
Paul POULAIN [Sat, 26 Mar 2011 22:17:58 +0000 (18:17 -0400)]
Bug 5982 : OPAC Serials Minor change in description

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 268f860e24171f3c5fe5f4b2c4a752e7c5abd5c1)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5972 - DisplayClearScreenButton preference introduces invalid markup
Owen Leonard [Sat, 26 Mar 2011 15:06:51 +0000 (11:06 -0400)]
Fix for Bug 5972 - DisplayClearScreenButton preference introduces invalid markup

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 735d986a0c976a888948ddd912917ad091267b7e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5971, Minor markup error in holds queue report
Owen Leonard [Sat, 26 Mar 2011 18:26:47 +0000 (14:26 -0400)]
Fix for Bug 5971, Minor markup error in holds queue report

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 84e43e06155e107e3965f06ea5ba37cc5d1b7d30)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4393: Scan Indexes results cannot be sorted
Jared Camins-Esakov [Sat, 26 Mar 2011 10:01:51 +0000 (06:01 -0400)]
Bug 4393: Scan Indexes results cannot be sorted

Because of the way Scan Indexes works, the results cannot be sorted. Previously
when any sort other than relevance (or in some cases popularity) was used, the
search failed. This patch disables sorting on Scan results. This patch also
fixes the index selection dropdown on the results page, which was not being
populated correctly from the Advanced Search screen.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 51604b548756fbf74620061a779d0182167c36f3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5964 : Translation problem on aqbudgets.tmpl
Henri-Damien LAURENT [Tue, 29 Mar 2011 16:04:21 +0000 (12:04 -0400)]
Bug 5964 : Translation problem on aqbudgets.tmpl

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 813f5c3f5164707041fcaa90839f4368355eb8e9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.07.000 v3.02.07
Chris Nighswonger [Sat, 16 Apr 2011 03:52:48 +0000 (23:52 -0400)]
Updating Version Number to 3.02.07.000

13 years agoRelease Notes for 3.02.07.000
Chris Nighswonger [Sat, 16 Apr 2011 03:51:20 +0000 (23:51 -0400)]
Release Notes for 3.02.07.000

13 years agoTranslations update for 3.2.7
Frédéric Demians [Fri, 15 Apr 2011 15:51:33 +0000 (17:51 +0200)]
Translations update for 3.2.7
(cherry picked from commit 742c92c778140fcd00edefb648db79d7ca53c229)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoPartial fix for Bug 4870, Damaged status does not prevent items from being selected...
Owen Leonard [Wed, 6 Apr 2011 07:51:45 +0000 (09:51 +0200)]
Partial fix for Bug 4870, Damaged status does not prevent items from being selected for reserves

This patch changes the holds queue build process in order to
require that items not be damaged in order to appear in the
holds queue report.

Revision adds a check for the AllowHoldsOnDamagedItems preference to
determine whether a damaged item should be included in the holds
queue report.

Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0f7411ceee5887751fb34ad2c72c83216d55f0c1)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug5555 Corrected search for ISBN / ISSN
Janusz Kaczmarek [Wed, 6 Apr 2011 07:36:22 +0000 (09:36 +0200)]
Bug5555 Corrected search for ISBN / ISSN

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ab7435f964336a18f760b9dd91d4b4506528a051)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5924 : C4::AuthoritiesMarc.pm search enhancement
Henri-Damien LAURENT [Tue, 5 Apr 2011 12:18:16 +0000 (14:18 +0200)]
Bug 5924 : C4::AuthoritiesMarc.pm search enhancement

Heading Main is defined in unimarc record.abs
re enabling that feature

Signed-off-by: fdurand <frederic.durand@univ-lyon2.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c19d505abb1b492cc21e6f5b78fb4de91da44419)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4196 - Defintion of popularity index into Unimarc setup
fdurand [Tue, 5 Apr 2011 15:07:30 +0000 (17:07 +0200)]
Bug 4196 - Defintion of popularity index into Unimarc setup

Signed-off-by: fdurand <frederic.durand@univ-lyon2.fr>
Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0c21ab2622d2d9b131c24c2002ed6e65875a6b24)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5410 : Adds "do-not-truncate" in the search queries of Heading.pm
Frédérick Capovilla [Tue, 5 Apr 2011 08:08:12 +0000 (10:08 +0200)]
Bug 5410 : Adds "do-not-truncate" in the search queries of Heading.pm

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0f4edffc16adacb439601f9051bacd89869018f7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6040 : Adding some error handling to the opac export
Chris Cormack [Tue, 5 Apr 2011 09:32:41 +0000 (11:32 +0200)]
Bug 6040 : Adding some error handling to the opac export

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 58013b6c2ad01b87c778ec56bf02dd58e826200e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6047: Remove check on subfield 3 that prevents biblios from BNF to create corresp...
Sophie Meynieux [Tue, 5 Apr 2011 12:44:07 +0000 (14:44 +0200)]
Bug 6047: Remove check on subfield 3 that prevents biblios from BNF to create corresponding authorities

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 96f054e90d4a582b13f1f6d2922b4ae99999a23d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5651: Question marks break searches w/ICU
Jared Camins-Esakov [Tue, 5 Apr 2011 13:48:03 +0000 (15:48 +0200)]
Bug 5651: Question marks break searches w/ICU

When a user is doing a simple keyword search, they should not be expected to
deal with the magical behavior of question marks in Zebra. This fix escapes
question marks, and reduces the number of false positives for identifying a
"simple keyword search."

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ad206a73f867f6a184f64d41e4ccfa8e5bb0cd21)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBZ6058: uncertain price can't be unchecked
Paul Poulain [Tue, 5 Apr 2011 12:05:57 +0000 (14:05 +0200)]
BZ6058: uncertain price can't be unchecked

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ce71043216f843ad1b1d2fb254db4dd2635e1066)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug #6044 - Authority is deleted when mergeto and mergefrom are the same
Alex Arnaud [Tue, 5 Apr 2011 12:11:00 +0000 (14:11 +0200)]
Bug #6044 - Authority is deleted when mergeto and mergefrom are the same

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e43da19e34745d734ab6ee5cb5540e4d6e92adf3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating history
Chris Cormack [Tue, 5 Apr 2011 07:27:15 +0000 (19:27 +1200)]
Updating history
(cherry picked from commit ff4645523b7e273438a4211ed4735f59084f5baf)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5962 : Budgets showing when they shouldn't (MT #4717) Bug in Koha 3.2 on acqui...
Christophe Croullebois [Mon, 4 Apr 2011 12:28:19 +0000 (14:28 +0200)]
Bug 5962 : Budgets showing when they shouldn't (MT #4717) Bug in Koha 3.2 on acqui-home.pl

In the screen all the budgets with budget_branchcode=NULL were displayed even if the budget_owner_id was not NULL. This patch fixes the bug

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
To test:
1) Add a new fund, leave library empty, owned by yourself
2) Go into the database and change aqbudgets.budget_branchcode to be NULL
3) Check acq home. Before patch the fund will not show up, although it's owned by you.
After patch it will.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5910b59d1d4bdbe6fb6152453536bfe64d490c01)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoCorrects an error when showing a suggestion linked to a deleted budget.
Frédérick Capovilla [Wed, 30 Mar 2011 16:12:19 +0000 (12:12 -0400)]
Corrects an error when showing a suggestion linked to a deleted budget.

If a suggestion is associated to a budget that was deleted, an error was
returned because we try to get the name of a budget that doesn't exist.
With this fix, the page is shown without errors.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0a43ba114d0fee9a478def455b926121442a0814)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6046: suggestedby list on she filter was not created properly
Paul Poulain [Mon, 4 Apr 2011 13:53:19 +0000 (15:53 +0200)]
Bug 6046: suggestedby list on she filter was not created properly

The suggestedby patron list contained empty lines. This was because retrieving patron name was not correct

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ff8ad64c2797d73464ef9009acba8744922fc61f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6043: SQL error when IndependantBranches=ON on suggestion
Paul Poulain [Mon, 4 Apr 2011 13:19:32 +0000 (15:19 +0200)]
Bug 6043: SQL error when IndependantBranches=ON on suggestion

On suggestion page, when IndependantBranch=ON, the SQL built is wrong:
branchcode is ambiguous

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 09e2ee605845e9cb03f21f2596404d60d1e9fc74)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6045: Accepted by is empty when accepting from list
Paul Poulain [Mon, 4 Apr 2011 14:28:44 +0000 (16:28 +0200)]
Bug 6045: Accepted by is empty when accepting from list

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a56e1e1729fbbc1b341bbad7c2fcf94d4642806f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.06.001
Chris Nighswonger [Mon, 11 Apr 2011 19:33:08 +0000 (15:33 -0400)]
Updating Version Number to 3.02.06.001

13 years agoBug 5860: Adding duplicate stocknumber fails silently
Katrin Fischer [Mon, 4 Apr 2011 11:20:20 +0000 (11:20 +0000)]
Bug 5860: Adding duplicate stocknumber fails silently

When adding a duplicate stocknumber the duplicate was not saved to the database.
This happened, because the field stocknumber in table items was declared to be unique.
Discussion on bug suggests to lift this restriction.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested. Corrected typo in updatedatabase script. Version 3.01.00.095 introduced the index with double s, although structure had only one s in index name.
Unaware of this bug, I entered the more general bug 6041 for similar problems with modifying items.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a8ffb2273b63c398492a7cbd08394adedb2aeadb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5989 - Funds filter does not remember library choice
Owen Leonard [Mon, 4 Apr 2011 10:25:55 +0000 (12:25 +0200)]
Fix for Bug 5989 - Funds filter does not remember library choice

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f22b8bcd458df8d8fad29070a7b95a63b6d356a2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6026 : export.pl : removing useless condition
Henri-Damien LAURENT [Fri, 1 Apr 2011 08:34:51 +0000 (10:34 +0200)]
Bug 6026 : export.pl : removing useless condition

Some conditions added AND items.biblionumber=biblio/biblionumber
where JOIN USING (biblionumber) already added that.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 63f1ea0c2dcd442ce0cb3b29d40f5015dceb5bab)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5625 : adding missing title (needed for lateorders.pl)
Paul POULAIN [Fri, 1 Apr 2011 15:04:47 +0000 (17:04 +0200)]
Bug 5625 : adding missing title (needed for lateorders.pl)

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 624ebb6e03bbf0f4c9f99298c0faed14bf4ed29b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>