From 6d2e0ded413b9f0af3d2ccd6951b00a2568f5954 Mon Sep 17 00:00:00 2001 From: Ian Walls Date: Sat, 8 Jan 2011 17:25:56 -0500 Subject: [PATCH] Bug 5603: advance_notice.pl uninitialized element in hash Changings one of the LEFT JOINS in C4::Members::Messaging::GetMessagingPreferences to a JOIN to prevent NULL message_transport_types from being returned Signed-off-by: Nicole Engard Signed-off-by: Chris Cormack (cherry picked from commit 8185db47878630399eedc8ca227ab0e111a3acad) Signed-off-by: Chris Nighswonger --- C4/Members/Messaging.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Members/Messaging.pm b/C4/Members/Messaging.pm index f5530e97c7..bc0f81b038 100644 --- a/C4/Members/Messaging.pm +++ b/C4/Members/Messaging.pm @@ -74,7 +74,7 @@ LEFT JOIN borrower_message_transport_preferences ON borrower_message_transport_preferences.borrower_message_preference_id = borrower_message_preferences.borrower_message_preference_id LEFT JOIN message_attributes ON message_attributes.message_attribute_id = borrower_message_preferences.message_attribute_id -LEFT JOIN message_transports +JOIN message_transports ON message_transports.message_attribute_id = message_attributes.message_attribute_id AND message_transports.message_transport_type = borrower_message_transport_preferences.message_transport_type WHERE message_attributes.message_name = ? -- 2.39.5