From ed1fc0cd06d73e7b13e7c68aaea0bb858c70f2ee Mon Sep 17 00:00:00 2001 From: Chris Cormack Date: Mon, 17 Jan 2011 22:53:28 +1300 Subject: [PATCH] Bug 5399: Follow up style patch, moving exits out of subroutine (cherry picked from commit 12741cfafa7513ee7b4627863c18346cb8507873) Signed-off-by: Chris Nighswonger --- acqui/basketgroup.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl index f21acfef42..0586323ad6 100755 --- a/acqui/basketgroup.pl +++ b/acqui/basketgroup.pl @@ -4,6 +4,7 @@ #written by john.soros@biblibre.com 01/10/2008 # Copyright 2008 - 2009 BibLibre SARL +# Parts Copyright Catalyst 2010 # # This file is part of Koha. # @@ -245,7 +246,6 @@ sub printbasketgrouppdf{ ); my $pdf = printpdf($basketgroup, $bookseller, $baskets, \%orders, $bookseller->{gstrate} || C4::Context->preference("gist")) || die "pdf generation failed"; print $pdf; - exit; # FIXME bad form to exit out of a subroutine like this } my $op = $input->param('op'); @@ -383,10 +383,12 @@ if ( $op eq "add" ) { CloseBasketgroup($basketgroupid); printbasketgrouppdf($basketgroupid); + exit; }elsif ($op eq 'print'){ my $basketgroupid = $input->param('basketgroupid'); printbasketgrouppdf($basketgroupid); + exit; }elsif( $op eq "delete"){ my $basketgroupid = $input->param('basketgroupid'); DelBasketgroup($basketgroupid); -- 2.39.5