]> git.koha-community.org Git - koha.git/commit
Bug 28409: Comprehensively validate category in opac-shelves.pl
authorDavid Cook <dcook@prosentient.com.au>
Fri, 21 May 2021 06:52:25 +0000 (06:52 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Thu, 24 Jun 2021 16:15:00 +0000 (12:15 -0400)
commit0ccf5fe83b4716472f4139735780c659c891719a
tree7a1f21fe8c01466fa70901a08ca1a520f1ba337a
parent4563a75c3576f08d370e089e4d3de288464930d3
Bug 28409: Comprehensively validate category in opac-shelves.pl

Default to a category of 1 (ie Private). Only allow input of 1
or 2 (ie Public)

== Test plan ==
1. Go to http://localhost:8080/cgi-bin/koha/opac-shelves.pl?category=function(){window.location.href%20=%20%27https://git.koha-community.org/stats/koha-master/authors.html%27}()
2. Note that you are redirected to another website
3. Go to http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=add&shelfname=foo&category=9
4. Note that you can't see this list in the Lists (but it has been added to the database)
5. Apply the patch & restart services
6. Go to http://localhost:8080/cgi-bin/koha/opac-shelves.pl?category=function(){window.location.href%20=%20%27https://git.koha-community.org/stats/koha-master/authors.html%27}()
7. Note that you are not redirected to another website
8. Go to http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=add&shelfname=bar&category=9
9. Note that "bar" has been added as a Private list

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
opac/opac-shelves.pl