]> git.koha-community.org Git - koha.git/commit
Bug 26464: Code correction in opac-main when news_id passed
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 15 Sep 2020 12:09:56 +0000 (12:09 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 16 Oct 2020 15:03:14 +0000 (15:03 +0000)
commit19a3ea8c968526cb5c8c3a94ce72e72e51856a03
tree43b8473810e4447d9284e8b3a9ed8f65908d2200
parentdeffb12491fa1a928a427b25f55ea5929f030266
Bug 26464: Code correction in opac-main when news_id passed

Theoretical change. If somehow the search would return more than one result, the code is wrong.

The if test can be simplified: remove scalar and >0.
We should not pass @array to one param. It would theoretically add wrong items or
trigger an odd number warning. If it is only one, it is no problem. But it is buggy.

Test plan:
Pass an existing news_id to opac-main. Item visible?
And pass a not-existing. Error message?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 22f14a7b6d45f3bf5ad57bd52203d4cdef724ce7)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
opac/opac-main.pl