]> git.koha-community.org Git - koha.git/commit
Bug 18725: (QA follow-up) Use make_column_dirty instead of status change
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 13 Apr 2018 07:38:50 +0000 (09:38 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 23 May 2018 05:09:06 +0000 (07:09 +0200)
commit26d56adbe9d06e259d28068987304ba5e323889c
tree0183cd2211d17174a14cf04235f80fab6a01256b
parentb4ad5070472c0e0f61e4ed016cdd23f6b8bd2dc8
Bug 18725: (QA follow-up) Use make_column_dirty instead of status change

Moving the status to the invalid 'processing' might well have unwanted
side-effects. (The status column will be set to empty string and we have
a problem if it is not processed.)

This patch allows pass-through of DBIX's make_column_dirty in
Koha::Object (simple tests included) and uses it to force an update.
If the update does not return true, it still exits.

Test plan:
[1] Read the changes.
[2] Run t/db_dependent/Koha/Object.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Conflicts:
Koha/Object.pm

(cherry picked from commit 40e865ba1632c002af37e9ddc1255bfacb3fd8d0)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Letters.pm
Koha/Object.pm
t/db_dependent/Koha/Object.t