]> git.koha-community.org Git - koha.git/commit
Bug 19126: Fix Members.t with IndependentBranches set
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 16 Aug 2017 11:15:19 +0000 (13:15 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 25 Aug 2017 15:12:04 +0000 (12:12 -0300)
commit44a8fc5b9363eb27223f32e1150fb8fff6f55d08
treec54ec3860ffba98a6951f3c2b10e61bc3d5cf8a8
parentb5d6a1885ed4dcb650e7f9f23733b4ff9ad2b37b
Bug 19126: Fix Members.t with IndependentBranches set

If you enabled that pref, Members.t fails with:
t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63.

The first one is:
t/db_dependent/Members.t .. 32/63
   Failed test 'Staff patron not deleted from list'
   at t/db_dependent/Members.t line 304.

Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the
state of this preference.
Trivially fixing it here by disabling the pref before the first call.

Test plan:
[1] Do not apply this patch yet. Enable IndependentBranches.
[2] Run Members.t and observe that it fails.
[3] Apply this patch. And run Members.t again. It should pass now.

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
t/db_dependent/Members.t