]> git.koha-community.org Git - koha.git/commit
Bug 35943: Fix group/subgroup filtering of saved reports
authorJulian Maurice <julian.maurice@biblibre.com>
Tue, 30 Jan 2024 14:13:47 +0000 (15:13 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 28 May 2024 15:47:51 +0000 (15:47 +0000)
commit71acdea01a5ddaa9cdc24843f1ea0779cb2b6805
tree6f63ab295bce08d33416e3ff0b5ce93ebb7bda6c
parent77b5822ed3147f97a71e8f064442f1fbd5a6c29d
Bug 35943: Fix group/subgroup filtering of saved reports

Use code instead of name for filtering and escape regexp special
characters.

This patch also disables datatables' smart filtering as it is not
recommended to use with regexp filtering

https://datatables.net/reference/api/search()

Test plan:
1. Create a report in a group named "Foo + Bar" and in a subgroup named
   "Baz + Quux"
2. Create other reports in group "Foo + Bar" but in other subgroups, as
   well as in other groups. This is useful to see the effect of
   filtering
3. Go to the saved reports page and verify that navigating between tabs
   have the desired result. Same for the subgroup select

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit de91b2e5d9dbff8c43a5090828397583bd397dc1)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit de13938d0af05445d32a8989d2eb7efe939b4658)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt