]> git.koha-community.org Git - koha.git/commit
Bug 26719: Replace MSG_NO_RECORD_SELECTED with translatable string
authorOwen Leonard <oleonard@myacpl.org>
Fri, 16 Oct 2020 18:08:44 +0000 (18:08 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Sun, 25 Oct 2020 23:14:41 +0000 (00:14 +0100)
commit8c99099e8c453be2e18d42ed1c0464fe9ff4824c
tree78aba856b0b68087eabf5acef8a6084746a50f0c
parent7a2cb71c79ae630bcfe6f4bcfe63bfbfeaf4f550
Bug 26719: Replace MSG_NO_RECORD_SELECTED with translatable string

This patch cleans up some loose ends left by Bug 25351, replacing
instances where the undefined variable MSG_NO_RECORD_SELECTED is used.

To test, apply the patch and perform a catalog search in the OPAC.

- On the search results page, without checking any checkboxes, use the
  "Select titles to..." menu to try to add to cart and add to a list. In
  each case you should get a "No item was selected" message.
- View a list which contains one or more titles. Click the "Remove
  from list" link. You should get a "No item was selected" link.

Other instances have been corrected even though they will only be
triggered if something has broken. For instance, toolbar items in the
cart window which are disabled shouldn't register the click that might
trigger the error. And selecting an item for an item-level hold
shouldn't ever give a warning because at least one radio button should
always be selected.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt