]> git.koha-community.org Git - koha.git/commit
Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 22 May 2020 12:29:20 +0000 (14:29 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 28 May 2020 15:02:26 +0000 (17:02 +0200)
commita79cf4150e8a08e743acc7d7147af91757d7a9b8
tree5bf47cb11c9f4f479d4ea86447a5fdb14a297414
parent9d8f9f1d3b0a10bc677904cd39764acbf4f75e13
Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON

This patch removes a problematic integer casting happening in TO_JSON.
The original need for this cast (a DBD::mysql bug) is now fixed. We
remove the cast as it is causing random failures.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/acquisitions_orders.t
=> FAIL: Tests fail with select high values (i.e. casting gives wrong
        results)
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests now pass!
5. Sign off :-D

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Object.pm