]> git.koha-community.org Git - koha.git/commit
Bug 29437: Search reservoir for term as title, author, or variations of ISBN
authorNick Clemens <nick@bywatersolutions.com>
Mon, 8 Nov 2021 19:24:36 +0000 (19:24 +0000)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Mon, 31 Jan 2022 00:09:39 +0000 (01:09 +0100)
commiteb2f2aa604902661b455d8602ebccddd0f3b5944
treea78611287e9131168a5851bfe39e6ffb8f83da68
parentac4c5b3eaa31a7688cde3274849a92534ebbda03
Bug 29437: Search reservoir for term as title, author, or variations of ISBN

The code in the script and the module attempt to determine whether a term is an isbn, or not. Rather
than try to do this, we can simply search it on the three fields: isbn, title, author

Additionally, we should search as any of the ISBN variations to broaden our matches

Note: Curently only an ISBN 10 is stored in import biblios, so for an ISBN13 that doesn't convert
the value will be blank - this is another bug

To test:
1 - Perform a cataloging search for a valid ISBN 13 with no ISBN10 counterpart:
    9798200834976
2 - 500 error
3 - Apply patch
4 - Repeat, no results
5 - Import some records
6 - Search by title/author/isbn
7 - Confirm searching works as expected

WNC amended to fix spelling

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
AMENDED: Useless call of ISBNs (plural) when you only pass one parameter.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit b422b7af2392440c5a4ca83b0740dceb262b9cd4)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
C4/Breeding.pm
cataloguing/addbooks.pl