]> git.koha-community.org Git - koha.git/commit
Bug 18725: (QA follow-up) Use make_column_dirty instead of status change
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 13 Apr 2018 07:38:50 +0000 (09:38 +0200)
committerNick Clemens <nick@bywatersolutions.com>
Tue, 22 May 2018 09:58:13 +0000 (09:58 +0000)
commit40e865ba1632c002af37e9ddc1255bfacb3fd8d0
tree7f824eb9c1496cf0685a63e197d23a8ecf03e098
parenta1e044094b2c29024dfe66b76c7bf2c619be0c7a
Bug 18725: (QA follow-up) Use make_column_dirty instead of status change

Moving the status to the invalid 'processing' might well have unwanted
side-effects. (The status column will be set to empty string and we have
a problem if it is not processed.)

This patch allows pass-through of DBIX's make_column_dirty in
Koha::Object (simple tests included) and uses it to force an update.
If the update does not return true, it still exits.

Test plan:
[1] Read the changes.
[2] Run t/db_dependent/Koha/Object.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Conflicts:
Koha/Object.pm
C4/Letters.pm
Koha/Object.pm
t/db_dependent/Koha/Object.t