]> git.koha-community.org Git - koha.git/commit
Bug 31202: Don't remove optional SIP fields with a value of "0"
authorKyle Hall <kyle@bywatersolutions.com>
Wed, 20 Jul 2022 16:32:58 +0000 (12:32 -0400)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 2 Sep 2022 14:46:50 +0000 (14:46 +0000)
commit5775f6c9a97bbfe15c1c496c6b2fdee856734cf1
treee02c7517788b389edddfc9110c6302f266743c53
parent7d2086663e64d1768f7a0206851fe857387db36d
Bug 31202: Don't remove optional SIP fields with a value of "0"

If the value of a SIP field is "0", that evaluates to false, so any calls to maybe_add with a value of "0" will not get added to the SIP response message.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

Signed-off-by: Michal Urban <michalurban177@gmail.com>
JK: Adjust commit title

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 8b957a69d4449bedd0f593cf946e5fde0e8d7a69)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/SIP/Sip.pm
t/db_dependent/SIP/Message.t