From 3447a782c2c3f95eee8dafb8bb5f450c044c4c17 Mon Sep 17 00:00:00 2001 From: Phil Ringnalda Date: Fri, 2 Oct 2020 15:35:04 -0700 Subject: [PATCH] Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record If you search for "this & that" and delete one of the results, after it is deleted the search in the reloaded page is for "this " rather than for "this & that". The template uses the url filter, which is for filtering an entire URI where :, &, #, etc. should be left alone, rather than the uri filter which is for filtering a URI component where they should be encoded. To test: 1) Go to Authorities > New authority > New from Z39.50/SRU 2) Search for the Author (corporate) this & that collective 3) Actions > Import, Save 4) From the detail for that authority, Edit > Edit as new (duplicate) 5) Edit the 110 field, add 2 at the end and Save 6) Search authorities for this & that 7) For one of the ones you created, Actions > Delete, confirm 8) The page that reloads should have a search for this & that, not just for this Signed-off-by: Didier Gautheron Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 16e5a9d8dcf7ab332a455ff74e23115fde27a10f) Signed-off-by: Lucas Gass (cherry picked from commit 54362935908bd9c2061598a9a150c721e620456d) Signed-off-by: Aleisha Amohia --- koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc index 555b8da0dc..1c160980db 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc @@ -46,7 +46,7 @@ function confirm_deletion(id) { + "&excluding=[% excluding | html %]" + "&operator=[% operator | html %]" + "&orderby=[% orderby | html %]" - + "&value=[% value |url %]" + + "&value=[% value |uri %]" + "&startfrom=[% startfrom | html %]" + "&resultsperpage=[% resultsperpage | html %]" + "&csrf_token=[% csrf_token | html %]"; -- 2.39.5