From 5a852cadaf9fddc38618e22d4fad1e1b7a3f9120 Mon Sep 17 00:00:00 2001
From: Fridolin Somers <fridolin.somers@biblibre.com>
Date: Fri, 17 Nov 2017 13:38:06 +0100
Subject: [PATCH] Bug 19646: fix value_builder marc21_linking_section template

When using marc21_linking_section cataloging plugin, you get the error :
Template process failed: undef error - The method selected is not
covered by tests! at /home/koha/src/C4/Templates.pm line 122.

It commes from [% IF ( itypeloo.selected ) %], selected is not defined
in itypeloo.

This patch removes this condition because all item types are fetched
from database, there is not one selected. It sets "All item types" as
selected. Also correctes two errors in HTML : ending form and div,
"<a_class=" instead of "<a class="

Test plan :
1) Use a MARC21 database
2) Define marc21_linking_section cataloging plugin in framework, on
   773$t for example
3) Create a new biblio record
4) Click on icon in 773$t
5) Check plugin works fine

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
 .../value_builder/marc21_linking_section.tt        | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt
index ba214da88b..63108a0da5 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt
@@ -124,13 +124,9 @@
                                <input type="text" name="search" id="searchbox" size="35" /><br />
                              <label for="itypeloop">Item type</label>
                                <select name="itype" id="itypeloop">
-                           <option value="">All Item Types</option>
+                           <option value="" selected="selected">All Item Types</option>
                                [% FOREACH itypeloo IN itypeloop %]
-                            [% IF ( itypeloo.selected ) %]
-                         <option value="[% itypeloo.itemtype %]" selected="selected">[% itypeloo.description %]</option>
-                                [% ELSE %]
                              <option value="[% itypeloo.itemtype %]">[% itypeloo.description %]</option>
-                            [% END %]
                               [% END %]
                               </select>
                       </p>
@@ -138,8 +134,8 @@
                             <input type="submit" value="Start search" />
                    </p>
 
-          </div>
- </form>
+            </form>
+        </div>
 
        [% ELSE %]
 
@@ -171,9 +167,9 @@
                                     [% IF ( resul.even ) %]<td class="hilighted">
                                     [% ELSE %]<td>[% END %]
                                                             [% IF ( resul.MARC_ON ) %]
-                                                                    <a_class="transparent resultlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resul.biblionumber |url %]">[% resul.title |html %]</a>
+                                                                    <a class="transparent resultlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resul.biblionumber |url %]">[% resul.title |html %]</a>
                                                             [% ELSE %]
-                                                                    <a_class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resul.biblionumber |url %]">[% resul.title |html %]</a>				[% END %]
+                                                                    <a class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resul.biblionumber |url %]">[% resul.title |html %]</a>				[% END %]
                                                     <p>[% resul.author %]
                                                     [% IF ( resul.publishercode ) %]- [% resul.publishercode %][% END %]
                                                     [% IF ( resul.place ) %] ; [% resul.place %][% END %]
-- 
2.39.5