]> git.koha-community.org Git - koha.git/commit
Bug 19126: Fix Members.t with IndependentBranches set
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 16 Aug 2017 11:15:19 +0000 (13:15 +0200)
committerKatrin Fischer <katrin.fischer.83@web.de>
Sun, 1 Oct 2017 22:19:46 +0000 (00:19 +0200)
commit1c0f36468749af352caac6e861a0ed514698adec
treeebbaad2acaf53f30ad4ee49e5c525da282ddb082
parentf3571db3365e7b6d3a25133e146992d73df38280
Bug 19126: Fix Members.t with IndependentBranches set

If you enabled that pref, Members.t fails with:
t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63.

The first one is:
t/db_dependent/Members.t .. 32/63
   Failed test 'Staff patron not deleted from list'
   at t/db_dependent/Members.t line 304.

Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the
state of this preference.
Trivially fixing it here by disabling the pref before the first call.

Test plan:
[1] Do not apply this patch yet. Enable IndependentBranches.
[2] Run Members.t and observe that it fails.
[3] Apply this patch. And run Members.t again. It should pass now.

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 44a8fc5b9363eb27223f32e1150fb8fff6f55d08)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 916d564055502aac3d09e227d90a0f3f6d291cdd)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
t/db_dependent/Members.t