]> git.koha-community.org Git - koha.git/commit
Bug 19088: plugins-upload causes error log noise
authorLee Jamison <ldjamison@marywood.edu>
Fri, 11 Aug 2017 18:58:53 +0000 (18:58 +0000)
committerKatrin Fischer <katrin.fischer.83@web.de>
Sun, 1 Oct 2017 22:23:41 +0000 (00:23 +0200)
commitba61c6b8054b34c58dc5914088c200fac529c402
tree81c79790cc116116d3eed444036c8dafa917e4f6
parent2ea0bac58bbe58f5fb53e66829e217ca87799928
Bug 19088: plugins-upload causes error log noise

After uploading a plugin the error log indicates
use of uninitialized value in $op. This patch
silences the noise.

To test:
1) Set <enable_plugins> to 1 (one) in koha-conf.xml.
2) Set the UseKohaPlugins system preference to 'Enable'.
3) Navigate to Administration -> Manage plugins.
4) Install the test plugin KPZ file attached to this bug.
5) Notice the uninitialized value noise in the error log.
6) Uninstall the plugin (plack restart may be required if plack is
    enabled).
7) Apply patch.
8) Install the plugin again.
9) Notice no noise in the error log.
10) Run qa tools.
11) Run prove t/db_dependent/Plugins.t

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 1076a0edf32b621da54c53ea71595885f7e14c38)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit cdcc0458b796aff59a50e0f5d4c7b7140682eacf)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
plugins/plugins-upload.pl