From 19c7e9905a47aede71bacb2d1762d5ef309eb635 Mon Sep 17 00:00:00 2001 From: Dobrica Pavlinusic Date: Fri, 1 Jun 2012 15:22:30 +0200 Subject: [PATCH] Bug 8178 - circ/circulation.pl under plack duplicates checkout rows Bug 7851 introduced our scoping for vairables, unfortunatly it has side-effect that checkout rows accumulate on page reloads instead of being initialized to empty array (which this patch fixes) This also fixes %renew_failed initialization on each request. Test scenario: 1. start intranet under plack 2. open /cgi-bin/koha/circ/circulation.pl and reload page few time confirming that rows gets duplicated 3. apply patch and reload page to verify that it works Signed-off-by: Alex Arnaud Signed-off-by: Paul Poulain Signed-off-by: Chris Cormack --- circ/circulation.pl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index 3e3c0e2cc6..14eaf1a29f 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -94,7 +94,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user ( my $branches = GetBranches(); my @failedrenews = $query->param('failedrenew'); # expected to be itemnumbers -our %renew_failed; +our %renew_failed = {}; for (@failedrenews) { $renew_failed{$_} = 1; } my $findborrower = $query->param('findborrower'); @@ -417,10 +417,10 @@ if ($borrowernumber) { # make the issued books table. my $todaysissues = ''; my $previssues = ''; -our @todaysissues; -our @previousissues; -our @relissues; -our @relprevissues; +our @todaysissues = (); +our @previousissues = (); +our @relissues = (); +our @relprevissues = (); my $displayrelissues; our $totalprice = 0; -- 2.39.5