From 1bbe1ea2681e542da2bcaa0a185227c206cddbf8 Mon Sep 17 00:00:00 2001 From: Ryan Higgins Date: Sat, 27 Sep 2008 12:57:08 -0500 Subject: [PATCH] Bug 2555 : label batch_id not properly incremented after batch num 10. This is a stop-gap fix intended for 3.0 maintenance release. 3.2 should include a label_batches table which will allow named batches to be associated with a template & layout, and fix the column definition of batch_id here to be an auto_incr int. Signed-off-by: Galen Charlton --- C4/Labels.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/C4/Labels.pm b/C4/Labels.pm index 6531164032..79d5251600 100644 --- a/C4/Labels.pm +++ b/C4/Labels.pm @@ -275,7 +275,9 @@ sub add_batch ($;$) { my $table = (@_ and 'patroncards' eq shift) ? 'patroncards' : 'labels'; my $batch_list = (@_) ? shift : undef; my $dbh = C4::Context->dbh; - my $q ="SELECT MAX(DISTINCT batch_id) FROM $table"; + # FIXME : batch_id should be an auto_incr INT. Temporarily casting as int ( see koha bug 2555 ) + # until a label_batches table is added, and we can convert batch_id to int. + my $q ="SELECT MAX( CAST(batch_id AS SIGNED) ) FROM $table"; my $sth = $dbh->prepare($q); $sth->execute(); my ($batch_id) = $sth->fetchrow_array || 0; -- 2.39.5