From 232a7a30666cc3082ae4e7b6b4828aef3e9c0039 Mon Sep 17 00:00:00 2001
From: Christopher Brannon <cbrannon@cdalibrary.org>
Date: Sun, 16 Sep 2018 22:06:10 +0000
Subject: [PATCH] Bug 13272: Adds type="text" to inputs missing it

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 92a2d74c1c134674b9798981208b9ad5863a6b42)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 5fbbdb915f9a41070ff71aac902622f0a7bb5ef7)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 .../intranet-tmpl/prog/en/includes/borrower_debarments.inc  | 4 ++--
 koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc     | 5 +++--
 koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc    | 4 ++--
 koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc    | 4 ++--
 koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc  | 4 ++--
 .../intranet-tmpl/prog/en/modules/acqui/z3950_search.tt     | 2 +-
 .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt      | 4 ++--
 .../prog/en/modules/cataloguing/z3950_auth_search.tt        | 2 +-
 .../prog/en/modules/cataloguing/z3950_search.tt             | 2 +-
 .../intranet-tmpl/prog/en/modules/circ/branchtransfers.tt   | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt     | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt       | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt     | 6 +++---
 .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +-
 .../intranet-tmpl/prog/en/modules/members/paycollect.tt     | 6 +++---
 koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt  | 4 ++--
 .../intranet-tmpl/prog/en/modules/tools/import_borrowers.tt | 4 ++--
 17 files changed, 30 insertions(+), 29 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc
index 7b4b25d7d1..38fd6bd826 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc
@@ -84,8 +84,8 @@
             <fieldset class="rows" id="manual_restriction_form">
                 <legend>Add manual restriction</legend>
                 <ol>
-                    <li><label for="rcomment">Comment:</label> <input type="text" id="rcomment" name="comment" /></li>
-                    <li><label for="rexpiration">Expiration:</label> <input name="expiration" id="rexpiration" size="10" value="" class="datepicker" />
+                    <li><label for="rcomment">Comment:</label> <input type="text" id="rcomment" name="comment" type="text" /></li>
+                    <li><label for="rexpiration">Expiration:</label> <input name="expiration" id="rexpiration" size="10" value="" class="datepicker" type="text" />
                         <a href="#" class="clear-date" id="clear-date-rexpiration">Clear date</a></li>
                 </ol>
             <fieldset class="action"><input type="submit" value="Add restriction" /> <a href="#" class="cancel" id="cancel_manual_restriction">Cancel</a></fieldset>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc
index ada7f193b4..fed4a65135 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc
@@ -9,14 +9,15 @@
 <div id="checkin_search" class="residentsearch">
     <p class="tip">Scan a barcode to check in:</p>
     <form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off">
-        <input class="head-searchbox" name="barcode" id="ret_barcode" size="40" />
+        <input class="head-searchbox" name="barcode" id="ret_barcode" size="40" type="text" />
+
         <input value="Submit" class="submit" type="submit" />
     </form>
 </div>
 <div id="renew_search" class="residentsearch">
     <p class="tip">Scan a barcode to renew:</p>
     <form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off">
-        <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" />
+        <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" type="text" />
         <input value="Submit" class="submit" type="submit" />
     </form>
 </div>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc
index 7fec2dd754..a5a9f277ac 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc
@@ -8,14 +8,14 @@
 <div id="checkin_search" class="residentsearch">
     <p class="tip">Scan a barcode to check in:</p>
     <form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off">
-        <input class="head-searchbox" name="barcode" id="ret_barcode" size="40" accesskey="r" />
+        <input class="head-searchbox" name="barcode" id="ret_barcode" size="40" accesskey="r" type="text" />
         <input value="Submit" class="submit" type="submit" />
     </form>
 </div>
 <div id="renew_search" class="residentsearch">
     <p class="tip">Scan a barcode to renew:</p>
     <form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off">
-        <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" />
+        <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" type="text" />
         <input value="Submit" class="submit" type="submit" />
     </form>
 </div>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc
index be87ac28c9..17ff3b292b 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc
@@ -8,14 +8,14 @@
 <div id="checkin_search" class="residentsearch">
     <p class="tip">Scan a barcode to check in:</p>
     <form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off">
-        <input name="barcode" class="head-searchbox" id="ret_barcode" size="40" accesskey="r" />
+        <input name="barcode" class="head-searchbox" id="ret_barcode" size="40" accesskey="r" type="text" />
         <input value="Submit" class="submit" type="submit" />
     </form>
 </div>
 <div id="renew_search" class="residentsearch">
     <p class="tip">Scan a barcode to renew:</p>
         <form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off">
-            <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" />
+            <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" type="text" />
             <input value="Submit" class="submit" type="submit" />
         </form>
     </div>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
index a10fc2fb7e..c9bf1997a8 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
@@ -123,14 +123,14 @@
     <div id="checkin_search" class="residentsearch">
     <p class="tip">Scan a barcode to check in:</p>
     <form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off">
-    <input class="head-searchbox" name="barcode" id="ret_barcode" size="40" accesskey="r" />
+    <input class="head-searchbox" name="barcode" id="ret_barcode" size="40" accesskey="r" type="text" />
     <input value="Submit" class="submit" type="submit" />
     </form>
     </div>
         <div id="renew_search" class="residentsearch">
         <p class="tip">Scan a barcode to renew:</p>
             <form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off">
-                <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" />
+                <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" type="text" />
                 <input value="Submit" class="submit" type="submit" />
             </form>
         </div>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
index 8cea37cb3d..08d882f9ad 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
@@ -197,7 +197,7 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color :
         [% IF ( show_nextbutton ) %]
             <input type="button" name="changepage_next" value="Next page" data-currentpage="[% current_page %]" />
         [% END %]
-        <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page %]" size="4" /><input type="submit" name="changepage_goto" value="Go" />
+        <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page | html %]" size="4" type="text" /> <input type="submit" name="changepage_goto" value="Go" />
     </form>
 
     [% ELSE %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
index 99c03d3443..168e2ab8de 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
@@ -624,8 +624,8 @@ $(document).ready(function() {
                         [% END %]
                         </select>
                     </td>
-                    <td><input name="maxissueqty" size="3" /></td>
-                    <td><input name="maxonsiteissueqty" size="3" /></td>
+                    <td><input name="maxissueqty" size="3" type="text" /></td>
+                    <td><input name="maxonsiteissueqty" size="3" type="text" /></td>
                     <td class="actions"><button type="submit" class="btn btn-default btn-xs"><i class="fa fa-plus"></i> Add</td>
                 </tr>
             </table>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt
index 6e6de65fa3..5bece97afc 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt
@@ -173,7 +173,7 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color :
         [% IF ( show_nextbutton ) %]
             <input type="button" name="changepage_next" value="Next page" data-currentpage="[% current_page %]" />
         [% END %]
-        <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page %]" size="4" /><input type="submit" name="changepage_goto" value="Go" />
+        <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page | html %]" size="4" type="text" /><input type="submit" name="changepage_goto" value="Go" />
     </form>
 
 <p><form method="get" action="/cgi-bin/koha/cataloguing/z3950_auth_search.pl"><input type="hidden" name="authid" value="[% authid %]" /><input type="submit" value="Try another search"/></form></p>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt
index 733c6b508d..23d9e77682 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt
@@ -208,7 +208,7 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color :
         [% IF ( show_nextbutton ) %]
             <input type="button" name="changepage_next" value="Next page" data-currentpage="[% current_page %]" />
         [% END %]
-        <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page %]" size="4" /><input type="submit" name="changepage_goto" value="Go" />
+        <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page | html %]" size="4" type="text" /><input type="submit" name="changepage_goto" value="Go" />
     </form>
 
     [% ELSE %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
index 3fc491cf2d..a4ba48754e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
@@ -152,7 +152,7 @@
             </li>
             <li>
                 <label for="barcode">Enter barcode: </label>
-                <input name="barcode" id="barcode" size="15" class="focus" /> <input type="submit" value="Submit" />
+                <input name="barcode" id="barcode" size="15" class="focus" type="text" /> <input type="submit" value="Submit" />
             </li>
 			</ol>
         </fieldset>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt
index 5eac258f29..577618ea07 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt
@@ -659,7 +659,7 @@ $(document).ready(function () {
                             <fieldset>
                                 <legend>Check In</legend>
                                 <label for="checkin-barcode">Enter item barcode: </label>
-                                <input name="barcode" id="checkin-barcode" size="14" class="focus"/>
+                                <input name="barcode" id="checkin-barcode" size="14" class="focus" type="text" />
                                 <input type="submit" class="submit" value="Submit" />
                             </fieldset>
                         </div>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt
index 835a61eb4d..bd4cfa2d63 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt
@@ -165,7 +165,7 @@
 
                             <label for="barcode">Enter item barcode: </label>
 
-                            <input name="barcode" id="barcode" size="14" class="focus"/>
+                            <input name="barcode" id="barcode" size="14" class="focus" type="text" />
 
                             <input type="submit" class="submit" value="Submit" />
                         </fieldset>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
index f3daa0e064..0761b6bbc1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
@@ -682,11 +682,11 @@ $(document).ready(function () {
 	<legend>Check in</legend>
             <label for="barcode">Enter item barcode: </label>
 			[% IF ( exemptfine ) %]
-			<input name="barcode" id="barcode" size="14" class="focus alert"/>
+			<input name="barcode" id="barcode" size="14" class="focus alert" type="text" />
 			[% ELSIF ( dropboxmode ) %]
-			<input name="barcode" id="barcode" size="14" class="focus alert"/>
+			<input name="barcode" id="barcode" size="14" class="focus alert" type="text" />
 			[% ELSE %]
-			<input name="barcode" id="barcode" size="14" class="focus"/>
+			<input name="barcode" id="barcode" size="14" class="focus" type="text" />
 			[% END %]
             <input type="submit" class="submit" value="Submit" />
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
index 7d03ab0f3f..c0b279614e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ -1064,7 +1064,7 @@ $(document).ready(function() {
                         <legend id="manual_restriction_lgd">Add manual restriction</legend>
                         <ol>
                             <li><label for="debarred_comment">Comment: </label><input type="text" id="debarred_comment" name="debarred_comment" onchange="$('#add_debarment').val(1);" /></li>
-                            <li><label for="debarred_expiration">Expiration: </label><input name="debarred_expiration" id="debarred_expiration" size="10" value="" class="datepicker" onchange="$('#add_debarment').val(1);" />
+                            <li><label for="debarred_expiration">Expiration: </label><input name="debarred_expiration" id="debarred_expiration" size="10" value="" class="datepicker" onchange="$('#add_debarment').val(1);" type="text" />
                                     <a href='javascript:void(0)' onclick="$('#debarred_expiration').val('');">Clear date</a></li>
 
                         </ol>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
index 1c196977f3..7938d0cd8c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
@@ -146,7 +146,7 @@ function moneyFormat(textObj) {
     <li>
         <label for="paid">Collect from patron: </label>
             <!-- default to paying all -->
-        <input name="paid" id="paid" value="[% amountoutstanding %]" />
+        <input name="paid" id="paid" value="[% amountoutstanding | html %]"  type="text" />
     </li>
 </ol>
 </fieldset>
@@ -194,7 +194,7 @@ function moneyFormat(textObj) {
                 <li>
                     <label for="paid">Writeoff amount: </label>
                     <!-- default to writing off all -->
-                    <input name="amountwrittenoff" id="amountwrittenoff" value="[% amountoutstanding %]" />
+                    <input name="amountwrittenoff" id="amountwrittenoff" value="[% amountoutstanding %]" type="text" />
                 </li>
             </ol>
         </fieldset>
@@ -219,7 +219,7 @@ function moneyFormat(textObj) {
     <li>
         <label for="paid">Collect from patron: </label>
         <!-- default to paying all -->
-        <input name="paid" id="paid" value="[% total | format('%.2f') %]" />
+        <input name="paid" id="paid" value="[% total | format('%.2f') %]" type="text" />
     </li>
     <li>
         <label for="selected_accts_notes">Note: </label>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
index 683164d0ae..3027492607 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
@@ -405,14 +405,14 @@ function checkMultiHold() {
 	[% IF ( reserve_in_future ) %]
 	<li>
         <label for="from">Hold starts on date:</label>
-        <input name="reserve_date" id="from" size="10" class="datepickerfrom">
+        <input name="reserve_date" id="from" size="10" class="datepickerfrom" type="text" >
         <a href="#" id="clear-date-from" class="clear-date">Clear date</a>
 	</li>
 	[% END %]
 
 	<li>
         <label for="to">Hold expires on date:</label>
-        <input name="expiration_date" id="to" size="10" class="datepickerto" />
+        <input name="expiration_date" id="to" size="10" class="datepickerto" / type="text" >
         <a href="#" id="clear-date-to" class="clear-date">Clear date</a>
 	</li>
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
index 7e8245d010..1de90e867b 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
@@ -167,14 +167,14 @@
   [% CASE %]
     <li>
         <label class="description" for="[% borrower_field.field %]">[% borrower_field.description %]: </label>
-        <input id="[% borrower_field.field %]" name="[% borrower_field.field %]" /><span class="field_hint">[% borrower_field.field %]</span>
+        <input id="[% borrower_field.field %]" name="[% borrower_field.field %]" type="text" /><span class="field_hint">[% borrower_field.field %]</span>
     </li>
   [% END %]
 [% END %]
 [% IF ( Koha.Preference('ExtendedPatronAttributes') == 1 ) %]
     <li>
         <label class="description" for="patron_attributes">Patron attributes: </label>
-        <input id="patron_attributes" name="patron_attributes" />
+        <input id="patron_attributes" name="patron_attributes" type="text" />
         <span class="field_hint">patron_attributes</span>
     </li>
 [% END %]
-- 
2.39.5