From 6431bf5d9a20737bcd6a8c4ac4426c5ba1bffd80 Mon Sep 17 00:00:00 2001
From: Aleisha Amohia <aleishaamohia@hotmail.com>
Date: Tue, 29 Aug 2017 04:51:40 +0000
Subject: [PATCH] Bug 19194: Check itemtype is defined when receiving an order

To test:
1) Find a record with an item that has no itemtype (or remove the
itemtype of an item)
2) Go to Acquisitions -> Find a vendor or make a new one -> create a new
basket
3) Add the record from Step 1 to your basket
4) Close the basket
5) Go back to the vendor and click 'Receive shipments'
6) Put in an invoice number, click Next
7) Click the Receive link for your item
8) Confirm you see an internal server error
9) Apply the patch and refresh the page
10) The error should be gone and behaviour should continue as expected

Sponsored-by: Catalyst IT

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 51a65731c0fa15c37351ce6bc478fa6dc63fc64f)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 acqui/orderreceive.pl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl
index 837a117b52..632a15d912 100755
--- a/acqui/orderreceive.pl
+++ b/acqui/orderreceive.pl
@@ -145,7 +145,9 @@ if ($AcqCreateItem eq 'receiving') {
         $item->{materials} = $descriptions->{lib} // '';
 
         my $itemtype = getitemtypeinfo($item->{itype});
-        $item->{itemtype} = $itemtype->{description};
+        if (defined $itemtype) {
+            $item->{itemtype} = $itemtype->{description};
+        }
         push @items, $item;
     }
     $template->param(items => \@items);
-- 
2.39.5