From 6eaf56ec67bdebb49b78ecf9e603b2ef7e95f4d5 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 6 Oct 2017 12:30:18 -0300 Subject: [PATCH] Bug 19423: Prevent DecreaseLoanHighHolds.t to fail randomly CanBookBeIssued returns STATS if categorycode is X Signed-off-by: Jonathan Druart (cherry picked from commit 090b450a502340e3d03b5ee6a075cc92e647aada) Signed-off-by: Fridolin Somers (cherry picked from commit fc4ee4aeec28c0f99e8432d4ce7748b7f628d85c) Signed-off-by: Katrin Fischer --- t/db_dependent/DecreaseLoanHighHolds.t | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/DecreaseLoanHighHolds.t b/t/db_dependent/DecreaseLoanHighHolds.t index ca14fb4bf4..15a097f258 100755 --- a/t/db_dependent/DecreaseLoanHighHolds.t +++ b/t/db_dependent/DecreaseLoanHighHolds.t @@ -50,10 +50,11 @@ C4::Context->_new_userenv('xxx'); C4::Context->set_userenv( 0, 0, 0, 'firstname', 'surname', $library->{branchcode}, 'Midway Public Library', '', '', '' ); is( C4::Context->userenv->{branch}, $library->{branchcode}, 'userenv set' ); +my $patron_category = $builder->build({ source => 'Category', value => { categorycode => 'NOT_X', category_type => 'P', enrolmentfee => 0 } }); my @patrons; for my $i ( 1 .. 20 ) { my $patron = Koha::Patron->new( - { cardnumber => $i, firstname => 'Kyle', surname => 'Hall', categorycode => $category->{categorycode}, branchcode => $library->{branchcode} } ) + { cardnumber => $i, firstname => 'Kyle', surname => 'Hall', categorycode => $category->{categorycode}, branchcode => $library->{branchcode}, categorycode => $patron_category->{categorycode}, } ) ->store(); push( @patrons, $patron ); } @@ -170,7 +171,7 @@ is( $data->{exceeded}, 1, "Should exceed threshold with one withdrawn item" ); C4::Context->set_preference('CircControl', 'PatronLibrary'); -my ( undef, $needsconfirmation ) = CanBookBeIssued( $patron_hr, $item->barcode ); +my ( $un, $needsconfirmation ) = CanBookBeIssued( $patron_hr, $item->barcode ); ok( $needsconfirmation->{HIGHHOLDS}, "High holds checkout needs confirmation" ); ( undef, $needsconfirmation ) = CanBookBeIssued( $patron_hr, $item->barcode, undef, undef, undef, { override_high_holds => 1 } ); -- 2.39.5