From 776151fdf31b292574e4c0bb0c4f185f59c8a218 Mon Sep 17 00:00:00 2001 From: Hayley Mapley Date: Wed, 8 May 2019 15:39:33 +1200 Subject: [PATCH] Bug 22724: Allow only users with correct permissions to 'Write off selected' Due to the addition of a 'Write off selected' button in 18.11, users without writeoff permissions could mistakenly view and action the 'Write off selected' option for a patron in Accounting > Make a payment (Fines > Pay fines). The attached patch corrects this error. Test plan: 1) Make sure that a staff user has '(writeoff) Write off fines and fees' permission disabled 2) Bring up a patron with an unpaid fee, go to Accounting -> Make a payment 3) Note that 'Write off selected' button is displayed. 4) Select a fee, click 'Write off selected'. Note that staff member has access to 'Write off an amount toward selected fines' 5) Apply the patch 6) Repeat steps 1-2, and note that the button is no longer displayed 7) Bonus points, as a staff user with writeoff permissions enabled check that all four buttons (Pay amount, Pay selected, Write off all, Write off selected) are displayed Sponsored-by: Catalyst IT Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Liz Rea Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens (cherry picked from commit d36566d6eaa9dd02528bbd1219747ccfd4e6b531) Signed-off-by: Martin Renvoize --- koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt index 6d8c942149..9f29f87abd 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt @@ -130,9 +130,9 @@
-[% IF CAN_user_updatecharges_writeoff %][% END %] - +[% IF CAN_user_updatecharges_writeoff %] +[% END %] Cancel
-- 2.39.5