From 7fef31478a825d678c6d8189f6038c764e612b42 Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Tue, 14 May 2019 08:22:43 +0200 Subject: [PATCH] Bug 22901: On items search fix search field change listening In items search, when there is a custom field with authorised values : when changing the conditional select AND/OR then the authorised values select disappears. This behaviour is like when the search field is changed. The bug is that JavaScript code meaning search field change listens on all selects instead of only search field select. Test plan : 1) Define a custom items search field with authorised values 2) Go to items search 3) Click on 'New field' 4) On second line, select custom field 5) The authorised values select appears 6) Select 'AND' in conditional select 7) Without patch the authorised values select disappears, with patch nothing changes 8) On second line, select a non-custom field 9) The authorised values select is replaced by a text field 10) On second line, select custom field 11) The authorised values select appears Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit e65b708f5385aa9df352cebe3c688a152fe1e176) Signed-off-by: Martin Renvoize --- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt index 1e334d94d5..6bbf38d372 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt @@ -422,7 +422,7 @@ form_field.append(button_field_new); // If a field is linked to an authorised values list, display the list. - $('div.form-field-select-text select').change(function() { + $('div.form-field-select-text select[name="f"]').change(function() { loadAuthorisedValuesSelect($(this)); }).change(); -- 2.39.5