From 1cd0e927e4dc1a557aafcbb9b93a7d8f4803e6ae Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 8 Mar 2021 15:24:14 +0000 Subject: [PATCH] Bug 27896: Remove DeleteTransfer from circ/return.pl This patch replaces the DeleteTransfer call in circ/returns.pl with a call to Koha::Item::Transfer->cancel. Test plan 1/ Check an item out 2/ Add a transfer request for the item to a second library 3/ Attempt to check the item in at the first library 4/ Note that you should be given a 'WrongTransfer' modal and have to option to cancel. 5/ Cancel the transfer 6/ Check in the database that the transfer now has 'datecancelled' set. 7/ Add a transfer for the item again 8/ From the transferstoreceive page cancel the transfer 9/ Click cancel and again check that datecancelled is set in the database for your transfer Signed-off-by: Petro Vashchuk Signed-off-by: Kyle M Hall Bug 27896: (follow-up) Fix Typo Signed-off-by: Petro Vashchuk Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart --- circ/returns.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/circ/returns.pl b/circ/returns.pl index 1e9b56ae6c..94e4b5e287 100755 --- a/circ/returns.pl +++ b/circ/returns.pl @@ -228,7 +228,9 @@ if ($dotransfer){ } if ($canceltransfer){ - DeleteTransfer($itemnumber); + my $item = Koha::Items->find($itemnumber); + my $transfer = $item->get_transfer; + $transfer->cancel({ reason => 'Manual', force => 1}); if($dest eq "ttr"){ print $query->redirect("/cgi-bin/koha/circ/transferstoreceive.pl"); exit; -- 2.39.5