From f6b729cd8dca3ad09a1dce4a6ea9515d1602e8c6 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Fri, 5 Jul 2024 14:42:18 +0000 Subject: [PATCH] Bug 37263: Fix handling of 'All' values on 'default article request fees' To test: 1. Enable ArticleRequests sys pref 2. Visit /cgi-bin/koha/admin/smart-rules.pl 3. Under 'Default article request fees' on 'Patron category' select 'All' and input a numeric Free 4. Click 'Add'. Notice it blows up. 5. Apply patch. Repeat. Signed-off-by: Roman Dolny Signed-off-by: Emmi Takkinen Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer (cherry picked from commit 84a31260ad8f875beb20ca83d2889ddd5503855f) --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt index d786284c3e..67e671590c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ -1046,7 +1046,7 @@ [% IF ( article_request_fee.defined && article_request_fee != '' ) %] - [% IF c == '*' %] + [% IF c == undef %] All [% ELSE %] [% Categories.GetName(c) | html %] -- 2.39.5