]> git.koha-community.org Git - koha.git/commit
Bug 32154: Missing primary key on erm_user_roles table
authorPedro Amorim <pedro.amorim@ptfs-europe.com>
Wed, 9 Nov 2022 17:55:20 +0000 (16:55 -0100)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 11 Nov 2022 11:54:34 +0000 (08:54 -0300)
commit22e78b5ffa9ddde3186c8a74e5771317d213d601
tree3cef55e655365121bb63d74132cf35f1e46dc6ee
parentb3be8b13140d67adb1eb18d3744af2daf3e16813
Bug 32154: Missing primary key on erm_user_roles table

The aforementioned TestBuilder should display "Koha::ERM::UserRole", not be empty.

This patch adds a primary key to the erm_user_roles table and fixes that.

Also includes atomicupdate file to update database schema as well as updates to
kohastructure.sql provided by Jonathan Druart.

Looked into the vue files but didn't find anywhere or a need to include the new
primary key in any of the requests as there is no request of users by role_user_id
being made.

Erm users are being created/updated as a relationship through licenceses/agreements.

Furthermore, when editing a role of an existing user, this new primary key is already
being supplied embeded in the license/agreement.

Test plan:
Add users to license and agreement
Run the cypress tests
Confirm that the change fix the test that was failing in TestBuilder.t
(another one may still fail however)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
api/v1/swagger/definitions/erm_user_role.yaml
installer/data/mysql/atomicupdate/erm.pl [new file with mode: 0644]
installer/data/mysql/kohastructure.sql