]> git.koha-community.org Git - koha.git/commit
Bug 18697: Final polishing
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 31 May 2017 14:19:35 +0000 (16:19 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 19 Jun 2017 18:35:51 +0000 (15:35 -0300)
commit4e9701c36a6743eff72b8127de2cc79ff463013b
tree0a65458a3dd3a9cbcc27e1aea3edb5e7d990361c
parent8eae9660839750d95c53f6cc2a4287a6196f0cc6
Bug 18697: Final polishing

GetFictiveIssueNumber:
Returns undef instead of 0 for irregular frequencies. Also added to POD.
Removed unused variable $wkno.
Adding a return makes the if(unit) unneeded.
Replaced (a+b)/b by 1+a/b.

_delta_units:
Added a comment about its parameters.

GetFictiveIssueNumber.t:
Adjusted the tests for irregular frequencies accordingly.

Test plan:
[1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t
[2] Run t/db_dependent/Serials/GetNextDate.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Serials.pm
t/db_dependent/Serials/GetFictiveIssueNumber.t