]> git.koha-community.org Git - koha.git/commit
Bug 28524: Escape 'rank' in cat_issues_top.pl
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 16 Jun 2021 12:51:08 +0000 (14:51 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 6 Jul 2021 08:12:58 +0000 (10:12 +0200)
commit5faddae26f7dd2c877161652f396414f56337421
tree81b26f7b6e26b9e8ec37fcc2a8c495b1e32fcec1
parent7d795fcf5f72e105667eb21e671fb1a63db8383b
Bug 28524: Escape 'rank' in cat_issues_top.pl

It's a MySQL 8 keyword

Test plan:
Turn off strict_sql_modes (there are other problems in this script)
Hit Home Reports > Most-circulated items
Submit the form

Without this patch you got:
  You have an error in your SQL syntax; check the manual that
  corresponds to your MySQL server version for the right syntax to use
  near 'RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM,
  ccode as CCODE, loca' at line 1

With this patch applied you see the report result view

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
reports/cat_issues_top.pl