Bug 36018: Rename orders->filter_by_current
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 21 Feb 2024 12:34:50 +0000 (12:34 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Fri, 10 May 2024 14:45:46 +0000 (16:45 +0200)
commitb7448dbd7531b24b7c54f254164881e144ce6b00
tree54eb54f05f33d0ba6db2e57a07b066cf7cd72247
parent2f702d2387a50790bd1cafbdf47b5010a482539d
Bug 36018: Rename orders->filter_by_current

Current is a bit misleading here. It means the ones that are not
cancelled.
We already use the filter_out_etc naming schema. So in harmony with
that, we switch it to filter_out_cancelled.

Test plan:
Run t/db_dependent/Koha/Acquisition/Order.t
Run git grep -l '::Orders' | xargs grep filter_by_current
* All occurrences should be related to Recalls, not Orders.
Go to acqui/basket.pl. Delete a whole basket who has some active
and some cancelled lines.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Koha/Acquisition/Orders.pm
acqui/basket.pl
t/db_dependent/Koha/Acquisition/Order.t