From 383ec1f51b4c505ac23471f8b5ee1622dc862787 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 9 Apr 2019 13:21:08 +0000 Subject: [PATCH] Bug 22553: Unchecking a subpermission does not uncheck the top level permission This patch makes a minor change to the set permissions page's JavaScript so that unchecking a subpermission will uncheck the top level permission. To test, apply the patch and open the "Set permissions" page for a patron. - Expand a permission with multiple subpermissions. - Check the top level permission. All subpermissions should be checked. - Uncheck one of the subpermissions. The top level permission should now be unchecked. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens --- .../prog/en/modules/members/member-flags.tt | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt index a777ddae2e..6c65d69039 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt @@ -195,13 +195,17 @@ $(".flag").on("change",function(e){ e.preventDefault(); - var bit = $(this).data("bit"); - if( $(this).is(":checked") ){ - $("#flag-" + bit + "-children").show().find(".flag").prop("checked", true); - $(".toggle-" + bit + ".togglechildren_on").hide(); - $(".toggle-" + bit + ".togglechildren_off").show(); + if( $(this).hasClass("child") ){ + $(this).closest(".parent").find(".flag.parent").prop("checked", false); } else { - $("#flag-" + bit + "-children").show().find(".flag").prop("checked", false); + var bit = $(this).data("bit"); + if( $(this).is(":checked") ){ + $("#flag-" + bit + "-children").show().find(".flag").prop("checked", true); + $(".toggle-" + bit + ".togglechildren_on").hide(); + $(".toggle-" + bit + ".togglechildren_off").show(); + } else { + $("#flag-" + bit + "-children").show().find(".flag").prop("checked", false); + } } }); -- 2.39.5