From 4715e38e6ab06715ab4b8fcfc588356b89b7aa08 Mon Sep 17 00:00:00 2001
From: Mason James <mtj@kohaaloha.com>
Date: Wed, 27 Jun 2012 01:22:21 +1200
Subject: [PATCH] Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in
 C4/Barcodes.pm

- "return" statement with explicit "undef" at line 57, column 2.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
---
 C4/Barcodes.pm | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/C4/Barcodes.pm b/C4/Barcodes.pm
index 2e81da60fe..b08d660165 100644
--- a/C4/Barcodes.pm
+++ b/C4/Barcodes.pm
@@ -55,7 +55,7 @@ sub initial {
 	return '0000001';
 }
 sub width {
-	return undef;
+	return;
 }
 sub process_head {	# (self,head,whole,specific)
 	my $self = shift;
@@ -129,7 +129,7 @@ sub next_value {
 	my ($head,$incr,$tail) = $self->parse($max);	# for incremental, you'd get ('',the_whole_barcode,'')
 	unless (defined $incr) {
 		warn "No incrementing part of barcode ($max) returned by parse.";
-		return undef;
+		return;
 	}
 	my $x = length($incr);		# number of digits
 	$incr =~ /^9+$/ and $x++;	# if they're all 9's, we need an extra.
@@ -145,17 +145,17 @@ sub next_value {
 	return $next_value;
 }
 sub next {
-	my $self = shift or return undef;
+	my $self = shift or return;
 	(@_) and $self->{next} = shift;
 	return $self->{next};
 }
 sub previous {
-	my $self = shift or return undef;
+	my $self = shift or return;
 	(@_) and $self->{previous} = shift;
 	return $self->{previous};
 }
 sub serial {
-	my $self = shift or return undef;
+	my $self = shift or return;
 	(@_) and $self->{serial} = shift;
 	return $self->{serial};
 }
@@ -192,11 +192,11 @@ sub new {
 	$autoBarcodeType =~ s/^.*:://;	# in case we get C4::Barcodes::incremental, we just want 'incremental'
 	unless ($autoBarcodeType) {
 		carp "No autoBarcode format found.";
-		return undef;
+		return;
 	}
 	unless (defined $types->{$autoBarcodeType}) {
 		carp "The autoBarcode format '$autoBarcodeType' is unrecognized.";
-		return undef;
+		return;
 	}
 	carp "autoBarcode format = $autoBarcodeType" if $debug;
 	my $self;
@@ -227,7 +227,7 @@ sub new {
 		return $self;
 	}
 	carp "Failed new C4::Barcodes::$autoBarcodeType";
-	return undef;
+	return;
 }
 
 sub new_object {
-- 
2.39.5