From 66ce3c1a8be1690eb6331d94564404e2687a20a2 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 5 Mar 2021 17:32:28 +0000 Subject: [PATCH] Bug 27885: Populate biblionumbers parameter using biblionumbers array Currently we send $biblionumbers as the parameter, but this is just apassthrough form when a list of biblios is selected for placing a hold If passed a single biblionumber we push it into @biblionumbers and use that for building the biblio loop This patch uses @biblionumbers to avoid sending a blank variable in the URL To test: 1 - On the staff client click 'place hold' for an individual record 2 - Use the form to find a patron 3 - Note the url is: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers= 4 - Apply patch 5 - Repeat 6 - The url is now like: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248 (but with whatever biblionumber you chose) 7 - Perform a search and select multiple biblios and confirm you can place holds as before Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall JD Amended patch: Add missing space Signed-off-by: Jonathan Druart --- reserve/request.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reserve/request.pl b/reserve/request.pl index a4563f34bb..a6fbe528f4 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -753,8 +753,8 @@ foreach my $biblionumber (@biblionumbers) { } $template->param( biblioloop => \@biblioloop ); -$template->param( biblionumbers => $biblionumbers ); $template->param( no_reserves_allowed => $no_reserves_allowed ); +$template->param( biblionumbers => join('/', @biblionumbers) ); $template->param( exceeded_maxreserves => $exceeded_maxreserves ); $template->param( exceeded_holds_per_record => $exceeded_holds_per_record ); $template->param( subscriptionsnumber => CountSubscriptionFromBiblionumber($biblionumber)); -- 2.39.5