From 7002e5d86af573359700d582c829af83acf87bc5 Mon Sep 17 00:00:00 2001 From: Paul Poulain Date: Fri, 2 Nov 2012 12:16:19 +0100 Subject: [PATCH] Bug 8490: fix Plack error when creating label layout This patch fixes "Error message "Can't bless non-reference value at /home/pi/koha/C4/Creators/Layout.pm line 111." when trying to add a label layout while using plack." The $layout_id variable is set to 5001 on my setup. And 5001 is the Unix port where I run Plack. WTH is this value stored in this variable ? Because of > my $layout_id = $cgi->param('layout_id') || $cgi->param('element_id') || $ARGV[1] || ''; in label-edit-layout.pl Removing $ARGV[1] solves the problem Also removing $ARG[0] because I also don't think it's useful Signed-off-by: Jared Camins-Esakov Signed off after confirming with Chris Nighswonger that these scripts were not intended to be run from the command line. Works as promised. Passed-QA-by: Jonathan Druart Signed-off-by: Jared Camins-Esakov --- labels/label-edit-layout.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/labels/label-edit-layout.pl b/labels/label-edit-layout.pl index 268912c393..e814e3b795 100755 --- a/labels/label-edit-layout.pl +++ b/labels/label-edit-layout.pl @@ -41,8 +41,8 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( } ); -my $op = $cgi->param('op') || $ARGV[0] || ''; -my $layout_id = $cgi->param('layout_id') || $cgi->param('element_id') || $ARGV[1] || ''; +my $op = $cgi->param('op') || ''; +my $layout_id = $cgi->param('layout_id') || $cgi->param('element_id') || ''; my $layout_choice = $cgi->param('layout_choice') || ''; our $layout = ''; -- 2.39.5