From 8d64bb9eb0555983936077b5fab4ca1a648b6871 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 16 Mar 2016 09:32:58 +0000 Subject: [PATCH] Bug 16073: (follow-up) Fix software error in circulation.pl Do not crash if the patron does not exist. Test plan: Access circ/circulation.pl?borrowernumber=42424242 you should get an error without this patch With this patch, you will get an empty patron detail page (should be fixed in another patch, but this behavior exists for a while) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com --- circ/circulation.pl | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index 74a7524c85..5cfd93f3ed 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -585,12 +585,13 @@ my $view = $batch my @relatives; if ( $borrowernumber ) { - my $patron = Koha::Patrons->find( $borrower->{borrowernumber} ); - if ( my $guarantor = $patron->guarantor ) { - push @relatives, $guarantor->borrowernumber; - push @relatives, $_->borrowernumber for $patron->siblings; - } else { - push @relatives, $_->borrowernumber for $patron->guarantees; + if ( my $patron = Koha::Patrons->find( $borrower->{borrowernumber} ) ) { + if ( my $guarantor = $patron->guarantor ) { + push @relatives, $guarantor->borrowernumber; + push @relatives, $_->borrowernumber for $patron->siblings; + } else { + push @relatives, $_->borrowernumber for $patron->guarantees; + } } } my $relatives_issues_count = -- 2.39.5