From 9f7186afd36af0ff3e3b6713636ff761278b865a Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 25 Apr 2012 08:33:21 -0400 Subject: [PATCH] Bug 8005 - Lost item is not anonymized when checked in This bug is caused by the subroutine C4::Circulation::LostItem not passing the privacy parameter when calling C4::Circulation::MarkIssueReturned. This issue is actually anonymized when the item is marked as lost, not when the item is checked in. Note, even if the issue is anonymized, the fine charged for lost items still contains a description of the lost item, which is required for the ability to forgive fees for lost items that are later found. Signed-off-by: Martin Renvoize Signed-off-by: Paul Poulain --- C4/Circulation.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 24c193acea..9b523e3a15 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -1529,6 +1529,7 @@ patron who last borrowed the book. sub AddReturn { my ( $barcode, $branch, $exemptfine, $dropbox ) = @_; + if ($branch and not GetBranchDetail($branch)) { warn "AddReturn error: branch '$branch' not found. Reverting to " . C4::Context->userenv->{'branch'}; undef $branch; @@ -1761,6 +1762,7 @@ routine in C. sub MarkIssueReturned { my ( $borrowernumber, $itemnumber, $dropbox_branch, $returndate, $privacy ) = @_; + my $dbh = C4::Context->dbh; my $query = 'UPDATE issues SET returndate='; my @bind; @@ -3102,12 +3104,13 @@ sub LostItem{ # if a borrower lost the item, add a replacement cost to the their record if ( my $borrowernumber = $issues->{borrowernumber} ){ + my $borrower = C4::Members::GetMemberDetails( $borrowernumber ); C4::Accounts::chargelostitem($borrowernumber, $itemnumber, $issues->{'replacementprice'}, "Lost Item $issues->{'title'} $issues->{'barcode'}") if $charge_fee; #FIXME : Should probably have a way to distinguish this from an item that really was returned. #warn " $issues->{'borrowernumber'} / $itemnumber "; - MarkIssueReturned($borrowernumber,$itemnumber) if $mark_returned; + MarkIssueReturned($borrowernumber,$itemnumber,undef,undef,$borrower->{'privacy'}) if $mark_returned; } } -- 2.39.5