From b865ff624c48f5ca2f9c30c75be903c1fb90ebc0 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 14:32:36 +1200 Subject: [PATCH] Bug 2505 - Add commented use warnings where missing in the acqui/ directory --- acqui/booksellers.pl | 1 + acqui/check_budget_total.pl | 1 + acqui/fetch_sort_dropbox.pl | 1 + acqui/histsearch.pl | 1 + acqui/neworderbiblio.pl | 1 + acqui/newordersuggestion.pl | 1 + acqui/orderreceive.pl | 2 +- acqui/parcel.pl | 4 ++-- acqui/supplier.pl | 1 + acqui/updatesupplier.pl | 3 ++- 10 files changed, 12 insertions(+), 4 deletions(-) diff --git a/acqui/booksellers.pl b/acqui/booksellers.pl index 11aba49c30..7641e689e6 100755 --- a/acqui/booksellers.pl +++ b/acqui/booksellers.pl @@ -53,6 +53,7 @@ the C we have to close if op is equal to 'close'. =cut use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use C4::Biblio; use C4::Output; diff --git a/acqui/check_budget_total.pl b/acqui/check_budget_total.pl index f3a1363277..62e545359c 100755 --- a/acqui/check_budget_total.pl +++ b/acqui/check_budget_total.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Output; diff --git a/acqui/fetch_sort_dropbox.pl b/acqui/fetch_sort_dropbox.pl index 3a04621418..1bc9332016 100755 --- a/acqui/fetch_sort_dropbox.pl +++ b/acqui/fetch_sort_dropbox.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Output; diff --git a/acqui/histsearch.pl b/acqui/histsearch.pl index 016bb05913..0190e4a688 100755 --- a/acqui/histsearch.pl +++ b/acqui/histsearch.pl @@ -48,6 +48,7 @@ to filter on ended date. =cut use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; # get_template_and_user use C4::Output; diff --git a/acqui/neworderbiblio.pl b/acqui/neworderbiblio.pl index c3f3396709..fcb4ffcde8 100755 --- a/acqui/neworderbiblio.pl +++ b/acqui/neworderbiblio.pl @@ -56,6 +56,7 @@ the basket number to know on which basket this script have to add a new order. =cut use strict; +#use warnings; FIXME - Bug 2505 use C4::Search; use CGI; diff --git a/acqui/newordersuggestion.pl b/acqui/newordersuggestion.pl index 4697800f75..ba966b6620 100755 --- a/acqui/newordersuggestion.pl +++ b/acqui/newordersuggestion.pl @@ -87,6 +87,7 @@ can be equal to =cut use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; # get_template_and_user diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl index b535af3e37..a1e6fce4b9 100755 --- a/acqui/orderreceive.pl +++ b/acqui/orderreceive.pl @@ -57,7 +57,7 @@ The biblionumber of this order. =cut use strict; -# use warnings; # FIXME +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Koha; # GetKohaAuthorisedValues GetItemTypes diff --git a/acqui/parcel.pl b/acqui/parcel.pl index f4a4b192f2..83fb45b509 100755 --- a/acqui/parcel.pl +++ b/acqui/parcel.pl @@ -52,6 +52,8 @@ To filter the results list on this given date. =cut +use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use C4::Acquisition; use C4::Budgets; @@ -63,8 +65,6 @@ use C4::Output; use C4::Dates qw/format_date format_date_in_iso/; use JSON; -use strict; - my $input=new CGI; my $supplierid=$input->param('supplierid'); my $bookseller=GetBookSellerFromId($supplierid); diff --git a/acqui/supplier.pl b/acqui/supplier.pl index e2d0a734c2..04bbe116c1 100755 --- a/acqui/supplier.pl +++ b/acqui/supplier.pl @@ -41,6 +41,7 @@ To know the bookseller this script has to display details. =cut use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use C4::Acquisition; use C4::Contract; diff --git a/acqui/updatesupplier.pl b/acqui/updatesupplier.pl index 8348a00292..e324a2915c 100755 --- a/acqui/updatesupplier.pl +++ b/acqui/updatesupplier.pl @@ -44,13 +44,14 @@ list_currency, gst, list_gst, invoice_gst, discount, gstrate. =back =cut +use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Auth; use C4::Bookseller; use C4::Biblio; use C4::Output; use CGI; -use strict; my $input=new CGI; my ($template, $loggedinuser, $cookie) = get_template_and_user( -- 2.39.5