From bdc06dd36f6651f0cc6d5f8a4140c50c75564c9f Mon Sep 17 00:00:00 2001
From: David Nind <david@davidnind.com>
Date: Mon, 6 May 2024 06:48:28 +0000
Subject: [PATCH] Bug 29948: (follow-up) Update system preference description
 and heading

This follow-up:
1. Updates the OPACAuthorIdentifiersAndInformation system preference
   description.
2. Changes the OPAC heading used on the bibliographic record and
   authority record detail pages from "Author identifiers/information"
   to "Author information". Identfiers are a subset of author information
   and having just "Author information" is sufficient. In addition,
   the authority record doesn't have to include identifiers.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../prog/en/modules/admin/preferences/opac.pref             | 6 ++----
 .../bootstrap/en/includes/authority-information.inc         | 6 +++---
 .../opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt      | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt     | 2 +-
 4 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
index 5de642f1cc..d1fd38b3f2 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
@@ -525,7 +525,7 @@ OPAC:
                   0: Disable
             - "interface for browsing all holdings (Elasticsearch only)."
         -
-            - "Display the following information for authors and contributors to the detail pages in the OPAC."
+            - "Display this information about authors and contributors on OPAC detail pages:"
             - pref: OPACAuthorIdentifiersAndInformation
               multiple_sortable:
                 activity: Activity (372$a$s$t)
@@ -537,9 +537,7 @@ OPAC:
                 place_of_birth: Place of birth (370$a)
                 place_of_death: Place of death (370$b)
                 uri: URI (371$u)
-            - "<p>Indentifiers: identifiers for authors and contributors to the detail pages in the OPAC."
-            - "This feature requires authorities with 024$2 and 024$a."
-            - "Valid source codes in $2 are currently: orcid, scopus, loop, rid and viaf.</p>"
+            - "<strong>NOTE:</strong> Identifiers for authors and contributors - valid codes to use in the source subfield (024$2) are currently: orcid (ORCID), scopus (ScopusID), loop (Loop ID), rid (Publons ID), and viaf (VIAF ID)."
         -
             - "Calculate the amount a patron has 'saved' by using the library based on replacement prices, and display:"
             - pref: OPACShowSavings
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-information.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-information.inc
index 5e1b748da6..53e391da2b 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-information.inc
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-information.inc
@@ -10,13 +10,13 @@
                 <span>ScopusID: </span>
                 <a href="https://www.scopus.com/authid/detail.uri?authorId=[% info.number | url %]">[% info.number | html %]</a>
             [% CASE 'loop' %]
-                <span>loop: </span>
+                <span>Loop ID: </span>
                 <a href="https://loop.frontiersin.org/people/[% info.number | url %]">[% info.number | html %]</a>
             [% CASE 'rid' %]
-                <span>Publons: </span>
+                <span>Publons ID: </span>
                 <a href="https://publons.com/researcher/[% info.number | url %]">[% info.number | html %]</a>
             [% CASE 'viaf' %]
-                <span>VIAF: </span>
+                <span>VIAF ID: </span>
                 <a href="https://viaf.org/viaf/[% info.number | url %]">[% info.number | html %]</a>
             [% END %]
         </li>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
index bd5bc10b82..c3db99c846 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
@@ -183,7 +183,7 @@
                         <div class="col-lg-6 order-lg-3">
                     [% END %]
                         <div class="author_identifier_info">
-                            <span>Identifiers/information</span>
+                            <span>Author information</span>
                             <ul>
                             [% FOR info IN Koha.Preference( 'OPACAuthorIdentifiersAndInformation' ).split(',') %]
                                 [% NEXT IF author_information.keys.grep(info).size <= 0 %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
index ea4e4fb0b6..7dd44416f5 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
@@ -497,7 +497,7 @@
                         [% IF Koha.Preference( 'OPACAuthorIdentifiersAndInformation' ) && author_information.size %]
                             [% WRAPPER tab_item tabname= "author_identifiers_info" %]
                                 [% IF Koha.Preference( 'OPACAuthorIdentifiersAndInformation' ) && author_information.size %]
-                                    <span>Author identifiers/information</span>
+                                    <span>Author information</span>
                                 [% END %]
                             [% END %]
                         [% END %]
-- 
2.39.5