From d23e50f0b239603a05ddbb62591e80657f5f6cae Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 11 Nov 2019 12:35:30 +0100 Subject: [PATCH] Bug 23822: Fix deletion of patrons with credit There are bugs in both master and 19.05, but different. Anyway we should have this check to make sure a negative value will have the same behavior: trigger the confirmation message (instead of a blank page). If we want to reject the deletion of a patron with credit we should handle it on a separate bug report (behavior change) Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize --- members/deletemem.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/members/deletemem.pl b/members/deletemem.pl index b30d28d5f6..5434cdfe53 100755 --- a/members/deletemem.pl +++ b/members/deletemem.pl @@ -104,7 +104,7 @@ if ( $op eq 'delete_confirm' or $countissues > 0 or $charges or $is_guarantor ) $template->param(ItemsOnHold => $countholds); } # This is silly written but reflect the same conditions as above - if ( not $countissues > 0 and not $charges and not $is_guarantor ) { + if ( not $countissues > 0 and not $charges > 0 and not $is_guarantor ) { $template->param( op => 'delete_confirm', csrf_token => Koha::Token->new->generate_csrf({ session_id => scalar $input->cookie('CGISESSID') }), -- 2.39.5