From dc2ad5fa9da6eecddffad8e47f7ba5f716229232 Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Sat, 17 Mar 2018 02:24:41 +0000 Subject: [PATCH] Bug 18797: Make rollingloans test useful TEST PLAN --------- 1) Run the following commands on a kohadevbox: kshell prove -v t/db_dependent/rollingloans.t exit -- all the tests were skipped, not useful! 2) Apply this patch 3) Redo step 1 -- all the tests run 4) Run qa test tools Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- t/db_dependent/rollingloans.t | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/rollingloans.t b/t/db_dependent/rollingloans.t index 17ff8db372..0ac7e6c4b6 100644 --- a/t/db_dependent/rollingloans.t +++ b/t/db_dependent/rollingloans.t @@ -1,3 +1,4 @@ +#!/usr/bin/perl use Modern::Perl; use C4::Context; @@ -7,6 +8,7 @@ use C4::Items; use Koha::DateUtils; use Koha::Patrons; use t::lib::TestBuilder; +use t::lib::Mocks qw(mock_preference); use Test::More tests => 8; @@ -17,7 +19,7 @@ C4::Context->_new_userenv(1234567); C4::Context->set_userenv(91, 'CLIstaff', '23529001223661', 'CPL', 'CPL', 'CPL', '', 'cc@cscnet.co.uk'); - +t::lib::Mocks::mock_preference('BlockReturnOfWithdrawnItems',0); my $test_patron = '23529001223651'; my $test_item_fic = '502326000402'; my $test_item_24 = '502326000404'; @@ -25,7 +27,24 @@ my $test_item_48 = '502326000403'; my $builder = t::lib::TestBuilder->new; my $borrower1 = $builder->build_object({ class => 'Koha::Patrons', value => { cardnumber => $test_patron } }); -my $item1 = GetItem (undef,$test_item_fic); +my $item1 = $builder->build_object({ + class => 'Koha::Items', + value => { + barcode => $test_item_fic, + } +}); +my $item2 = $builder->build_object({ + class => 'Koha::Items', + value => { + barcode => $test_item_24, + } +}); +my $item3 = $builder->build_object({ + class => 'Koha::Items', + value => { + barcode => $test_item_48, + } +}); SKIP: { skip 'Missing test borrower or item, skipping tests', 8 @@ -49,7 +68,7 @@ sub try_issue { my $patron = Koha::Patrons->find( { cardnumber => $cardnumber } ); my ($issuingimpossible,$needsconfirmation) = CanBookBeIssued( $patron, $item ); my $issue = AddIssue($patron->unblessed, $item, undef, 0, $issuedate); - return dt_from_string( $issue->due_date() ); + return dt_from_string( $issue->date_due ); } sub try_return { -- 2.39.5